Split service code#2136
Merged
Merged
Conversation
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
…hat take dataclasses (#2013) Signed-off-by: jason.lai <jasonlai1218@gmail.com>
Signed-off-by: troychiu <y.troychiu@gmail.com>
* Error when multiple configuration plugins are installed Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * Adds semi-colon Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> --------- Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: pryce-turner <pryce.turner@gmail.com>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
Signed-off-by: nikki everett <nikki@union.ai>
* added _cmd_prefix handling Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed typing imports Signed-off-by: Daniel Rammer <daniel@union.ai> * add get_config Signed-off-by: Kevin Su <pingsutw@apache.org> * updating get_config to use underlying functions config Signed-off-by: Daniel Rammer <daniel@union.ai> --------- Signed-off-by: Daniel Rammer <daniel@union.ai> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: DouEnergy <douenergy@protonmail.com>
Signed-off-by: Austin Liu <austin362667@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
* Accelerator docs Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> * updating docs Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> * Updated docs Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> * updated docs Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> * more docs update Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> * updated Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> * updated docs Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> --------- Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> Co-authored-by: Ketan Umare <kumare3@users.noreply.github.com>
* Add support for running remote-tasks and remote-workflows Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> * updated Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> --------- Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> Co-authored-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Bumps [fonttools](https://github.com/fonttools/fonttools) from 4.41.1 to 4.43.0. - [Release notes](https://github.com/fonttools/fonttools/releases) - [Changelog](https://github.com/fonttools/fonttools/blob/main/NEWS.rst) - [Commits](fonttools/fonttools@4.41.1...4.43.0) --- updated-dependencies: - dependency-name: fonttools dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add monodocs index page in flytekit Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * updates Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
* add monodocs redirects to the flytekit readthedocs project Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * update requirements Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * add redirects enabling flag Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * update Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Future Outlier <eric901201@gmai.com> Co-authored-by: Future Outlier <eric901201@gmai.com>
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.2...3.1.3) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.2...3.1.3) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Future Outlier <eric901201@gmai.com> Co-authored-by: Future Outlier <eric901201@gmai.com>
) Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.2...3.1.3) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.2...3.1.3) --- updated-dependencies: - dependency-name: jinja2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Future Outlier <eric901201@gmai.com> Co-authored-by: Future Outlier <eric901201@gmai.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
…2127) Bumps [pillow](https://github.com/python-pillow/Pillow) from 10.1.0 to 10.2.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@10.1.0...10.2.0) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
squiishyy
approved these changes
Jan 30, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## artifacts #2136 +/- ##
==============================================
+ Coverage 53.53% 75.11% +21.57%
==============================================
Files 178 177 -1
Lines 17617 17482 -135
Branches 3656 3618 -38
==============================================
+ Hits 9431 13131 +3700
+ Misses 7755 3742 -4013
- Partials 431 609 +178 ☔ View full report in Codecov by Sentry. |
Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.8.6 to 3.9.2. - [Release notes](https://github.com/aio-libs/aiohttp/releases) - [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst) - [Commits](aio-libs/aiohttp@v3.8.6...v3.9.2) --- updated-dependencies: - dependency-name: aiohttp dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.9.1 to 3.9.2. - [Release notes](https://github.com/aio-libs/aiohttp/releases) - [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst) - [Commits](aio-libs/aiohttp@v3.9.1...v3.9.2) --- updated-dependencies: - dependency-name: aiohttp dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.9.0 to 3.9.2. - [Release notes](https://github.com/aio-libs/aiohttp/releases) - [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst) - [Commits](aio-libs/aiohttp@v3.9.0...v3.9.2) --- updated-dependencies: - dependency-name: aiohttp dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.9.1 to 3.9.2. - [Release notes](https://github.com/aio-libs/aiohttp/releases) - [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst) - [Commits](aio-libs/aiohttp@v3.9.1...v3.9.2) --- updated-dependencies: - dependency-name: aiohttp dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#2126) Bumps [pillow](https://github.com/python-pillow/Pillow) from 10.1.0 to 10.2.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@10.1.0...10.2.0) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
* Pass environment variables to local executions Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Pass environment variables to local executions Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix test_get_entities_in_file Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Lint Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
* Add output_entity_hint and support for serialising it Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Correct assertion Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Add output_entity_hint to task decorator Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Type hints Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Fix circular import of type hints Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Support iterable of output_entity_hints (#5) Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Fix circular import for type hints Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Fix tests Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Auto-format Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Add positive test case Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Add a test for disallowing entity hints on static tasks Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * raise instead of assert Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Rename output_entity_hints -> node_dependency_hints Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Update docstrings Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Auto-format Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Fix test_serialize_vscode Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Maybe fix the docs error Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Fix a newly added test from master Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Fix monodocs build Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> --------- Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
* Warn user when overriding requests but not limits Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> * Lint Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> --------- Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> Co-authored-by: Fabio Grätz <fabiogratz@googlemail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Future Outlier <eric901201@gmai.com> Signed-off-by: Kevin Su <pingsutw@gmail.com> Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: Future Outlier <eric901201@gmai.com> Co-authored-by: Kevin Su <pingsutw@gmail.com>
…ng fails (#2047) * Improve error message in workflow compliation when output binding fails Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com> * Include previous exception in error message Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com> * Adapt tests Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com> * Add test that would have caught issue Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com> * Silence expected mypy warning in test Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com> * Use FlyteValidationException instead of AssertionError Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> * Use FlyteValidationException instead of AssertionError Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> * Lint Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> --------- Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com> Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> Co-authored-by: Fabio Grätz <fabiogratz@googlemail.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
eapolinario
added a commit
that referenced
this pull request
Feb 8, 2024
* temp Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * stuff Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * temp Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * scaffolding areas mostly identified Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add artifact to upload request Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * remove an unnecessary line in workflow Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * finish adding examples use cases maybe Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add project/dom to get query Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add from flyte idl Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add project domain to as query Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add condition in parameter to flyte idl Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * test stuff * Remove artifactID from literal oneof, add to metadata (#2) * Triggers (#6) * Minor changes to get time series example working #8 Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * switch channel (#10) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * fix tests ignore - pr into other pr (#1858) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Artf/update idl ux (#1920) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Artf/trigger (#1948) * Add triggers * Remove bind_partition_time and just assume users won't use that. It's just time_partition in the normal call function now. Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * remove the now deleted artifact spec (#1984) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Literal metadata model update (#2089) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Separate time partition (#2114) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Split service code (#2136) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * remove empty files Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add noneness check to metadata and add test Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * remove sandbox test for now Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Artf/cleanup (#2158) * add a test Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * try updates Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> --------- Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Use python 3.9 to run make doc-requirements.txt Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * reasons not msg Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> --------- Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
added a commit
that referenced
this pull request
Feb 8, 2024
* temp Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * stuff Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * temp Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * scaffolding areas mostly identified Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add artifact to upload request Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * remove an unnecessary line in workflow Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * finish adding examples use cases maybe Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add project/dom to get query Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add from flyte idl Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add project domain to as query Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add condition in parameter to flyte idl Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * test stuff * Remove artifactID from literal oneof, add to metadata (#2) * Triggers (#6) * Minor changes to get time series example working #8 Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * switch channel (#10) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * fix tests ignore - pr into other pr (#1858) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Artf/update idl ux (#1920) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Artf/trigger (#1948) * Add triggers * Remove bind_partition_time and just assume users won't use that. It's just time_partition in the normal call function now. Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * remove the now deleted artifact spec (#1984) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Literal metadata model update (#2089) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Separate time partition (#2114) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Split service code (#2136) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * remove empty files Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add noneness check to metadata and add test Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * remove sandbox test for now Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Artf/cleanup (#2158) * add a test Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * try updates Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> --------- Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Use python 3.9 to run make doc-requirements.txt Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * reasons not msg Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> --------- Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out the implementation of the service for now.