Remove storage as a task resource option

[Future-Outlier]

Tracking issue

Fixes flyteorg/flyte#3955

Why are the changes needed?

Make the storage unused in the task resource option, so that users will not be confused about why they can define the storage but it didn't work.

What changes were proposed in this pull request?

Remove all variables with task resource storage.
Search variable like this.

How was this patch tested?

1. run flytekit task with specified resource
2. use kubectl describe nodeId to check if the Resources as expected

Success Scenario

from flytekit import task, Resources

@task(
        requests=Resources(cpu="2", ephemeral_storage="200Mi", mem="200Mi"),
)
def test_storage() -> None:
    import time
    print("@@@ I am sleeping for 10 seconds")
    time.sleep(10)
    return

pyflyte run --remote remove_resource_storage.py test_storage

kubectl describe pod ff436fac5f4d74583b75-f4wb3a3y-0 -n flytesnacks-development

The output is below.

    Limits:
      cpu:                2
      ephemeral-storage:  200Mi
      memory:             200Mi
    Requests:
      cpu:                2
      ephemeral-storage:  200Mi
      memory:             200Mi

Failure Scenario

from flytekit import task, Resources

@task(
        requests=Resources(cpu="2", storage="200Mi"),
)
def test_storage() -> None:
    import time
    print("@@@ I am sleeping for 10 seconds")
    time.sleep(10)
    return

pyflyte run --remote remove_resource_storage.py test_storage

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

flyteorg/flyte#4658

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e107994) 85.71% compared to head (4591da1) 85.73%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2078      +/-   ##
==========================================
+ Coverage   85.71%   85.73%   +0.01%     
==========================================
  Files         313      313              
  Lines       23396    23383      -13     
  Branches     3501     3497       -4     
==========================================
- Hits        20055    20048       -7     
+ Misses       2733     2729       -4     
+ Partials      608      606       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Future-Outlier]

@katrogan Please take a look, thanks a lot!