Skip to content

Allows Secret groups to be optional and configurable#2062

Merged
pingsutw merged 21 commits into
flyteorg:masterfrom
thomasjpfan:secret_plugin_hook
Dec 22, 2023
Merged

Allows Secret groups to be optional and configurable#2062
pingsutw merged 21 commits into
flyteorg:masterfrom
thomasjpfan:secret_plugin_hook

Conversation

@thomasjpfan

@thomasjpfan thomasjpfan commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

Why are the changes needed?

This PR enables third party configuration plugins to disable the groups when specifying secrets.

What changes were proposed in this pull request?

This PR adds secret_requires_group to the Plugin Configuration API. This allows plugins to disable groups for specifying secrets.

For this to work, the external configuration plugin needs to be installed locally and on the remote machine.

How was this patch tested?

Unit tests were added to check that secret groups can be disabled through with the Plugin Configuration API.

Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
@codecov

codecov Bot commented Dec 20, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fccf7c7) 86.05% compared to head (8fdb32c) 86.06%.

Files Patch % Lines
flytekit/models/security.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2062      +/-   ##
==========================================
+ Coverage   86.05%   86.06%   +0.01%     
==========================================
  Files         313      313              
  Lines       23344    23351       +7     
  Branches     3489     3491       +2     
==========================================
+ Hits        20088    20097       +9     
+ Misses       2644     2643       -1     
+ Partials      612      611       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
@thomasjpfan thomasjpfan marked this pull request as draft December 21, 2023 16:03
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
@thomasjpfan thomasjpfan marked this pull request as ready for review December 21, 2023 16:15
@pingsutw pingsutw merged commit 68430db into flyteorg:master Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants