Improve error message for pyflyte run#2142
Merged
Merged
Conversation
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2142 +/- ##
==========================================
+ Coverage 83.01% 85.80% +2.79%
==========================================
Files 176 313 +137
Lines 17116 23579 +6463
Branches 3530 3530
==========================================
+ Hits 14208 20231 +6023
- Misses 2298 2738 +440
Partials 610 610 ☔ View full report in Codecov by Sentry. |
eapolinario
approved these changes
Jan 30, 2024
eapolinario
left a comment
Collaborator
There was a problem hiding this comment.
Can we do a similar exercise with inexistent tasks too? In a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Improve error message
What changes were proposed in this pull request?
raise an error if file not found
How was this patch tested?
Before:
After:
Check all the applicable boxes