Warn user when overriding requests but not limits

[fg91]

Why are the changes needed?

@task(
    requests=Resources(
        cpu="3",
        mem="3Gi",
    ),
)
def foo():
    ...



@workflow
def my_wf():
    foo().with_overrides(
        requests=Resources(
            cpu="5",
            mem="5Gi",
        ),
    )

As a user, I would expect that the resulting task pod has 5 vCPUs and 5Gi or RAM. Turns out, the task pod has 3 each!

This behaviour is very unintuitive, the reason being as follows:

• When one doesn't explicitly set limits on a task, the requests are taken as limits as well.
• When one only overrides the requests, the requests are clamped to the old limits in the backend.

What changes were proposed in this pull request?

In this PR I add a warning so that at least users are warned to set limit as well.

How was this patch tested?

Running the above workflow with pyflyte -v run --remote ... results in the following new log line:

Requests overridden on node n0 (<FlyteLiteral name: "foo" retries { }>) without specifying limits. Requests are clamped to original limits.

The fact that -v is required to see this warning unfortunately limits its usefulness. Maybe this warrants a discussion whether this behaviour should be changed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1789db9) 50.76% compared to head (5abeeef) 85.80%.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #2151       +/-   ##
===========================================
+ Coverage   50.76%   85.80%   +35.03%     
===========================================
  Files         176      313      +137     
  Lines       17116    23581     +6465     
  Branches     3530     3531        +1     
===========================================
+ Hits         8689    20233    +11544     
+ Misses       8000     2738     -5262     
- Partials      427      610      +183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pingsutw]

Thank you