Skip to content

Print log links in local execution#2097

Merged
pingsutw merged 3 commits into
masterfrom
log-link
Jan 10, 2024
Merged

Print log links in local execution#2097
pingsutw merged 3 commits into
masterfrom
log-link

Conversation

@pingsutw

Copy link
Copy Markdown
Member

Tracking issue

flyteorg/flyte#3936

Why are the changes needed?

Show the log link during local executions

What changes were proposed in this pull request?

Screenshots

image

Related PRs

Docs link

Signed-off-by: Kevin Su <pingsutw@apache.org>
@codecov

codecov Bot commented Jan 10, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5841a1e) 85.77% compared to head (1f8e377) 85.73%.
Report is 6 commits behind head on master.

Files Patch % Lines
flytekit/extend/backend/base_agent.py 25.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2097      +/-   ##
==========================================
- Coverage   85.77%   85.73%   -0.04%     
==========================================
  Files         313      313              
  Lines       23426    23448      +22     
  Branches     3510     3514       +4     
==========================================
+ Hits        20093    20103      +10     
- Misses       2727     2735       +8     
- Partials      606      610       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw merged commit dc35e7f into master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants