node_dependency_hints for dynamic tasks#2015
Merged
eapolinario merged 20 commits intoJan 31, 2024
Merged
Conversation
2 tasks
Tom-Newton
force-pushed
the
tomnewton/upsream_output_entity_hints
branch
from
5fe0ef7 to
45b9b19
Compare
Contributor
Author
|
Looks like I created a circular imports with the type hints when rebasing |
pingsutw
reviewed
Dec 13, 2023
Tom-Newton
force-pushed
the
tomnewton/upsream_output_entity_hints
branch
from
6920d5b to
25fa4dd
Compare
Contributor
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2015 +/- ##
=======================================
Coverage 85.80% 85.80%
=======================================
Files 313 313
Lines 23579 23594 +15
Branches 3530 3534 +4
=======================================
+ Hits 20232 20246 +14
Misses 2738 2738
- Partials 609 610 +1 ☔ View full report in Codecov by Sentry. |
Tom-Newton
force-pushed
the
tomnewton/upsream_output_entity_hints
branch
3 times, most recently
from
23aaf8f to
b629c6f
Compare
Tom-Newton
changed the title
Tom-Newton
force-pushed
the
tomnewton/upsream_output_entity_hints
branch
3 times, most recently
from
7d3e25a to
5fc0f47
Compare
Tom-Newton
changed the title
node_dependency_hints for dynamic tasks
Tom-Newton
requested review from
cosmicBboy,
eapolinario,
kumare3 and
wild-endeavor
as code owners
Tom-Newton
force-pushed
the
tomnewton/upsream_output_entity_hints
branch
2 times, most recently
from
8f8e46d to
920a5d2
Compare
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Tom-Newton
force-pushed
the
tomnewton/upsream_output_entity_hints
branch
from
920a5d2 to
a29cd98
Compare
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Tom-Newton
force-pushed
the
tomnewton/upsream_output_entity_hints
branch
from
a29cd98 to
62c5209
Compare
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
pingsutw
approved these changes
Jan 30, 2024
eapolinario
approved these changes
Jan 30, 2024
…ntity_hints Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
approved these changes
Jan 30, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#4516
Why are the changes needed?
Streamline launching launchplans from dynamic tasks.
What changes were proposed in this pull request?
How was this patch tested?
Updated unit tests. I have also been using very similar changes in a real flyte deployment for weeks.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link