Remove unnecessary newline in plugin README#2090
Merged
samhita-alla merged 1 commit intoJan 6, 2024
Merged
Conversation
douenergy
requested review from
cosmicBboy,
eapolinario,
kumare3,
pingsutw and
wild-endeavor
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: DouEnergy <douenergy@protonmail.com>
douenergy
force-pushed
the
remove-unnecessary-newline
branch
from
a190acc to
c11d507
Compare
Contributor
Author
|
@pingsutw Please take a look 👀 |
pingsutw
approved these changes
Jan 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2090 +/- ##
==========================================
- Coverage 85.75% 85.12% -0.64%
==========================================
Files 313 284 -29
Lines 23433 22089 -1344
Branches 3511 3511
==========================================
- Hits 20096 18803 -1293
+ Misses 2730 2678 -52
- Partials 607 608 +1 ☔ View full report in Codecov by Sentry. |
|
Congrats on merging your first pull request! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
None
Why are the changes needed?
Currently, the placement of DuckDB in the README is not consistent with the other plugins.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link