Envvars local execution#2132
Merged
Merged
Conversation
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
requested review from
cosmicBboy,
kumare3,
pingsutw and
wild-endeavor
as code owners
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2132 +/- ##
==========================================
+ Coverage 83.01% 85.15% +2.14%
==========================================
Files 176 279 +103
Lines 17116 21700 +4584
Branches 3530 3530
==========================================
+ Hits 14208 18479 +4271
- Misses 2298 2611 +313
Partials 610 610 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
cosmicBboy
approved these changes
Jan 30, 2024
pingsutw
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#4503
Why are the changes needed?
We introduced the ability to pass environment variables from the command line when using
pyflyte runin #1617, however that only works for remote executions. This PR enables this for local executions as well.What changes were proposed in this pull request?
Set environment variables prior to executing Flyte entities locally.
How was this patch tested?
Unit tests and local.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link