Generalized subproc_execute and added tests#2072
Merged
Merged
Conversation
Signed-off-by: pryce-turner <pryce.turner@gmail.com>
pryce-turner
requested review from
cosmicBboy,
eapolinario,
pingsutw and
wild-endeavor
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2072 +/- ##
==========================================
+ Coverage 85.71% 85.73% +0.01%
==========================================
Files 313 313
Lines 23396 23398 +2
Branches 3501 3501
==========================================
+ Hits 20055 20061 +6
+ Misses 2733 2730 -3
+ Partials 608 607 -1 ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
subproc_execute was too restrictive, this allows passing of arbitrary kwargs with sensible defaults
What changes were proposed in this pull request?
modified subproc_execute and 2 tests for shell and non-shell exec
How was this patch tested?
2 unit tests