add monodocs redirects to the flytekit readthedocs project#2095
Merged
Conversation
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
cosmicBboy
requested review from
eapolinario,
kumare3,
pingsutw and
wild-endeavor
as code owners
pingsutw
previously approved these changes
Jan 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2095 +/- ##
==========================================
- Coverage 85.73% 84.48% -1.26%
==========================================
Files 313 313
Lines 23435 23448 +13
Branches 3512 3514 +2
==========================================
- Hits 20093 19811 -282
- Misses 2734 3015 +281
- Partials 608 622 +14 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
neverett
approved these changes
Jan 11, 2024
wild-endeavor
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially addresses flyteorg/flyte#4579, adding redirects just to the old flytesnacks docs https://docs.flyte.org/projects/flytekit/en/stable/ to the new monodocs: https://docs.flyte.org/en/latest/
Each page in the old docs manually maps to the new one.