Deploy Checklist: New Expensify 2022-01-18

[OSBotify]

Release Version: 1.1.31-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Add default/delete popover and supporting methods #4437

  • QA
  • Accessibility

• Add password to AddDebitCardPage in NewDot  #6882

  • QA
  • Accessibility

• Make About footer links accessible #7061

  • QA
  • Accessibility

• Updated Amount validation conditions to not allow indefinite zeroes at the start. #7104

  • QA
  • Accessibility

• Cut report last message to specified length #7124

  • QA
  • Accessibility

• fix: Change emoji navigation with arrow keys #7127

  • QA
  • Accessibility

• Firefox TextArea height issue #7210

  • QA
  • Accessibility

• [NO QA] ignore "coverage" folder generated by Jest #7214

  • QA
  • Accessibility

• Hide debit card behind wallet beta #7215

  • QA
  • Accessibility

• Fixes IOU - Unable to paste the amount copied from Notes on MacOS Safari #7219

  • QA
  • Accessibility

• Do not show "Message <user>" button when seeing your own profile #7228

  • QA
  • Accessibility

• Fix: background highlighting 🔦 issue for offline messages #7230

  • QA
  • Accessibility

• fix workspace save btn float issue #7240

  • QA
  • Accessibility

• [No QA] Update es translations for 'privacy' and 'invite' #7249

  • QA
  • Accessibility

• [NO-QA]Add Workflow run URL to triggerWorkflowAndWait #7250

  • QA
  • Accessibility

• Upgrade RN-web #7254

  • QA
  • Accessibility

• [No QA] fix: Fixed error with frequently used emojis not showing up #7255

  • QA
  • Accessibility

• Fix : Chat moves up a bit when new message is received #7271

  • QA
  • Accessibility

• [NO QA] Fix formatting for ease of reading #7276

  • QA
  • Accessibility

• [CP Staging] Fix document upload on Android #7277

  • QA
  • Accessibility

• Fix/7122 views overlap #7280

  • QA
  • Accessibility

• Quick cancel bugfix #7281

  • QA
  • Accessibility

• Only passing sections that contain data #7285

  • QA
  • Accessibility

• [No QA] Cleanup - Remove keyboard type numeric, and incorrect uses of phone-pad. #7287

  • QA
  • Accessibility

• fix: misspelled copy in bank account validation step #7289

  • QA
  • Accessibility

• No wrap style #7339

  • QA
  • Accessibility

Deploy Blockers:

• Emojis - "Frequently Used" header is missing in emojis categories #7258
• Debit card - Card declined message when entering incorrect Expensify Password #7310
• IOS/Android - Text with over 6 makes message box scroll #7320
• mWeb - Group chat - Members of the group in header is going above the boundary #7321

cc @Expensify/applauseleads

[mvtglobally]

Starting QA

[stitesExpensify]

Checking off #4437

[chiragsalian]

Hows QA going along @mvtglobally? 🙂

[mvtglobally]

@chiragsalian QA is almost done. I will be updating checkboxes in the next hr.

[mvtglobally]

#6882 is failing due to #7310
#7104 is failing due to
#7210 is failing due to #7320
#7271 is still repro #7271 (comment)
#7289 is failing with console error #7293. Can we check off?

[chiragsalian]

#7289 is failing with console error #7293. Can we check off?

Yes, looks like its not breaking anything and there is a GH issue recorded. So yeah feel free to check it off.

[chiragsalian]

#7104 is failing due to

Why was #7104 failing? I don't see any comment here or on the issue.

It also looks like #7310 was closed. Can you retest #6882 or ask the author for clarification if there is some confusion there?

[chiragsalian]

• Looks like #6882 was retested.
• Could you explain where #7104 was failing.
• I think #7320 is a non issue (explained here) so #7210 can be tested again
• #7271 looks legit. Not a blocker though so we can ignore that for now as we work on other stuff.
• I'll check #7289 (my reasoning posted here).

[mvtglobally]

Checking off #7271 & #7210
#7104 has an issue with leading zeroes. I was waiting for the team to confirm. Will update in another min

[mvtglobally]

@chiragsalian Updated the comment. We are not sure if this is expected or no. This is the last open PR on the checklist and once confirmed, we should be ok to deploy.
#7104 (comment)

[mvtglobally]

checking of #7104 based on the #7104 (comment)

[chiragsalian]

Just addressed #7321 and i've asked @kavimuru to retest.
The PR that resolved the issue is #7339. So once it's tested we can check off both and I'll be clear to deploy.