Add password to AddDebitCardPage in NewDot #6882
Conversation
|
This is ready for review! Since it needs to be deployed with the Auth and Web-Secure changes, I'll keep it on hold until all 3 PRs are approved! |
|
Bumping for review! |
MonilBhavsar
left a comment
There was a problem hiding this comment.
Apologies for the delay here.
Looks good to me 👍
Feel free to merge after merging backend!
|
Thanks for the review @MonilBhavsar! No longer on hold, merging. |
|
@luacmartins looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
All tests passed before merging. Removing |
|
🚀 Deployed to staging by @luacmartins in version: 1.1.30-4 🚀
|
|
🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀
|
Details
Adds a password requirement on the AddDebitCardPage.
We are ignoring the forgot password flow for now, as we still haven't landed on a solution.
Fixed Issues
https://github.com/Expensify/Expensify/issues/188051 (partial)
Tests
Settings > Payments > Add payment method > Debit cardIncorrect Expensify password entered.QA Steps
Please note that actual password enforcement will only happen after these two PRs are merged as well: https://github.com/Expensify/Auth/pull/6271 and https://github.com/Expensify/Web-Secure/pull/2124. Before that, entering a wrong password wouldn't display an error and the card will still be added.
Follow steps above.
Tested On
Screenshots
Web
web.mov
Mobile Web
Desktop
desktop.mov
iOS
ios.mp4
Android
android.mov