Skip to content

Add password to AddDebitCardPage in NewDot #6882

Merged
luacmartins merged 23 commits into
mainfrom
cmartins-debitCardPassword
Jan 17, 2022
Merged

Add password to AddDebitCardPage in NewDot #6882
luacmartins merged 23 commits into
mainfrom
cmartins-debitCardPassword

Conversation

@luacmartins

@luacmartins luacmartins commented Dec 22, 2021

Copy link
Copy Markdown
Contributor

Details

Adds a password requirement on the AddDebitCardPage.
We are ignoring the forgot password flow for now, as we still haven't landed on a solution.

Fixed Issues

https://github.com/Expensify/Expensify/issues/188051 (partial)

Tests

  1. Pull the changes in Auth and Web-Secure
  2. Log into NewDot and navigate to Settings > Payments > Add payment method > Debit card
  3. Try to submit an empty form and verify that you see an error for the password input.
  4. Now fill in all the necessary information (enter 4242 4242 4242 4242 for credit card number), but use a wrong password.
  5. Submit the form and verify that you see the following message: Incorrect Expensify password entered.
  6. Now enter your correct Expensify password and submit the form again.
  7. Verify that the card was added.

QA Steps

Please note that actual password enforcement will only happen after these two PRs are merged as well: https://github.com/Expensify/Auth/pull/6271 and https://github.com/Expensify/Web-Secure/pull/2124. Before that, entering a wrong password wouldn't display an error and the card will still be added.

Follow steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

Desktop

desktop.mov

iOS

ios.mp4

Android

android.mov

@luacmartins luacmartins self-assigned this Dec 22, 2021
@luacmartins luacmartins changed the title Add password requirement when setting up debit card in NewDot [HOLD] Add password requirement when setting up debit card in NewDot Dec 29, 2021
@luacmartins luacmartins changed the title [HOLD] Add password requirement when setting up debit card in NewDot [HOLD] Add password to AddDebitCardPage in NewDot Jan 5, 2022
@luacmartins luacmartins marked this pull request as ready for review January 7, 2022 20:18
@luacmartins luacmartins requested a review from a team as a code owner January 7, 2022 20:18
@luacmartins

Copy link
Copy Markdown
Contributor Author

This is ready for review! Since it needs to be deployed with the Auth and Web-Secure changes, I'll keep it on hold until all 3 PRs are approved!

@MelvinBot MelvinBot removed the request for review from a team January 7, 2022 20:19
@MelvinBot MelvinBot requested a review from MonilBhavsar January 7, 2022 20:19
@luacmartins

Copy link
Copy Markdown
Contributor Author

Bumping for review!

@MonilBhavsar MonilBhavsar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay here.
Looks good to me 👍
Feel free to merge after merging backend!

@luacmartins

Copy link
Copy Markdown
Contributor Author

Thanks for the review @MonilBhavsar! No longer on hold, merging.

@luacmartins luacmartins changed the title [HOLD] Add password to AddDebitCardPage in NewDot Add password to AddDebitCardPage in NewDot Jan 17, 2022
@luacmartins luacmartins merged commit c224cfe into main Jan 17, 2022
@luacmartins luacmartins deleted the cmartins-debitCardPassword branch January 17, 2022 16:59
@botify

botify commented Jan 17, 2022

Copy link
Copy Markdown

@luacmartins looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@luacmartins

Copy link
Copy Markdown
Contributor Author

All tests passed before merging. Removing Emergency label.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.30-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants