Skip to content

Hide debit card behind wallet beta#7215

Merged
joelbettner merged 2 commits into
mainfrom
stites-hideAddDebitCard
Jan 17, 2022
Merged

Hide debit card behind wallet beta#7215
joelbettner merged 2 commits into
mainfrom
stites-hideAddDebitCard

Conversation

@stitesExpensify

Copy link
Copy Markdown
Contributor

Details

We only want people on the wallet beta to be able to add debit cards.

Fixed Issues

$ #7212

Tests

  1. Change this line to always return false
  2. Log into an account
  3. Go to Settings -> Payments
  4. Click "Add Payment Methods"
  5. Make sure you don't see the debit card option

QA Steps

  1. Log into an account not in the wallet beta
  2. Go to Settings -> Payments
  3. Click "Add Payment Methods"
  4. Make sure you don't see the debit card option

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

2022-01-13_14-41-54

@stitesExpensify stitesExpensify requested a review from a team as a code owner January 13, 2022 21:48
@stitesExpensify stitesExpensify self-assigned this Jan 13, 2022
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team January 13, 2022 21:48

@joelbettner joelbettner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but have we also made sure that a debit card can't be added in the PHP/Auth layers unless the user is on the beta?

@joelbettner joelbettner merged commit dc2b32e into main Jan 17, 2022
@joelbettner joelbettner deleted the stites-hideAddDebitCard branch January 17, 2022 19:01
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @joelbettner in version: 1.1.30-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants