Firefox TextArea height issue

[kursat]

Details

Firefox adds height to the TextArea to reserve place for scroll-bars. Because of that, initial heights are different in firefox and chrome. This causes scrollHeight difference and height issue on firefox.

Fixed Issues

$ #7103

Tests

• Verify that no errors appear in the JS console

1. Go to a conversation
2. In compose textarea verify "Write something..." aligned correctly.
3. Verify empty textarea is 1 line.
4. Verify text with 2+ lines is not scrolling.
5. Edit a previous message.
6. Repeat 3 and 4.

QA Steps

• Verify that no errors appear in the JS console

1. Go to a conversation
2. In compose textarea verify "Write something..." aligned correctly.
3. Verify empty textarea is 1 line.
4. Verify text with 2+ lines is not scrolling.
5. Edit a previous message.
6. Repeat 3 and 4.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

number-of-rows-chrome.mp4

number-of-rows-firefox.mp4

Mobile Web

number-of-rows-chrome-mobile.mp4

number-of-rows-firefox-mobile.mp4

Desktop

number-of-rows-desktop.mp4

iOS

number-of-rows-ios.mp4

Android

number-of-rows-android.mp4

[kursat]

Hey, I'll add desktop and ios screenshots asap.

[kursat]

updated

[rushatgabhane]

@kursat Looks like there's some extra height at the top for iOS

[kursat]

Hey @rushatgabhane, I checked this problem, it was already there before my solution. Should I still fix that? If I should, should I cancel the PR and re-propose?

@kursat Looks like there's some extra height at the top for iOS

[rushatgabhane]

@kursat thanks so much for checking it out! In that case, no need to fix it in this PR. It's unrelated to the issue.

[rushatgabhane]

LGTM! 🎉
All yours @NikkiWines

[NikkiWines]

👍 Looks good

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[NikkiWines]

@kursat just FYI I believe we generally prefer to have more descriptive PR titles

[kursat]

Hey @NikkiWines, sorry I didn't notice the title. It was my branch name. Will be more careful next time.

[OSBotify]

🚀 Deployed to staging by @NikkiWines in version: 1.1.30-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅