Fix : Chat moves up a bit when new message is received by ahmdshrif · Pull Request #7271 · Expensify/App

ahmdshrif · 2022-01-16T19:18:58Z

Details

fix Chat moves up a bit when new message is received for ios

Fixed Issues

$ #7145

Tests

Verify that no errors appear in the JS console

QA Steps

Open a room and scroll to earlier message (fastly)
Stay on specific message (to read it or something)
Send new message to that room
Verify that chat view is not moving around when new message is received

Verify that no errors appear in the JS console

Tested On

Screenshots

Web

web-chat-move-up.mov

Mobile Web

Screen_Recording_20220116-221221_Samsung.Internet.mp4

Desktop

desktop.mov

iOS

Screen.Recording.2022-01-16.at.6.04.52.PM.mov

Android

mountiny

Looks good to me! Good find here @ahmdshrif:)

I will wait for Rushat to test this and approve it before going ahead.

rushatgabhane · 2022-01-16T19:42:18Z

I'm testing for regressions. Meanwhile, @ahmdshrif please add screenshots for all platforms. Thanks a lot! 😃

ahmdshrif · 2022-01-16T20:23:59Z

@rushatgabhane I have already included a video for all platforms except android since it still has the issue.

rushatgabhane

@mountiny Looks good to me too! Couldn't find any regressions.

mountiny

Nice! Thank you very much @rushatgabhane and @ahmdshrif!

mountiny · 2022-01-16T22:56:16Z

Yikes, I cant merge this as your commit is not signed it seems @ahmdshrif :/

Would you be able to follow these instructions and I guess force push to this branch to sign the commit. https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#begin-coding-your-solution-in-a-pull-request

Thank you!

ahmdshrif · 2022-01-16T23:56:23Z

@mountiny ok, I signed it and delete the not-signed commit.

mountiny

Thank you @ahmdshrif!

ahmdshrif · 2022-01-17T02:18:24Z

sorry for that again. but my commit was signed but was not verified so I again push force verified sign commit and that dismiss your reviews.
@mountiny @rushatgabhane

mountiny · 2022-01-17T08:59:17Z

Thank you!

mountiny · 2022-01-17T13:04:42Z

Test passed so going ahead and merging.

OSBotify · 2022-01-17T13:05:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-01-18T22:45:31Z

🚀 Deployed to staging by @mountiny in version: 1.1.30-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kbecciv · 2022-01-19T16:19:42Z

@ahmdshrif @rushatgabhane @r8 The issue is reproduced during Regression.

moves.1901.mp4

ahmdshrif · 2022-01-19T16:32:51Z

@kbecciv think the issue is defined on android and ios only.

Platform:

Where is this issue occurring?

iOS

Android

Version Number: 1.1.27-0 Reproducible in staging?: Y Reproducible in production?: Y Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1641962371.MP4
Expensify/Expensify Issue URL: Issue reported by: @K4tsuki Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1641188993370400

rushatgabhane · 2022-01-19T17:40:30Z

Alright, this issue is happening on Safari only (both web and mWeb)

It's reproducible on main too for Safari.

ahmdshrif · 2022-01-19T17:44:31Z

Yes i test it on mobile (not safari) work

Screen_Recording_20220119-194225_Samsung.Internet.mp4

rushatgabhane · 2022-01-19T17:45:29Z

@ahmdshrif any ideas how to fix this? (Safari only issue)

mountiny · 2022-01-19T18:35:08Z

Yeah, we have missed that case to test, maybe we should explicitly state it in the PR checklist too. Would you be able to look into the safari issue @ahmdshrif, please?

ahmdshrif · 2022-01-20T07:42:44Z

@mountiny @rushatgabhane
I try to debug this but do not have a solution for now. it looks like the flatlist for web use something not supported on safari.

I test it with and without my code. it's happened on safari in both cases.

mountiny · 2022-01-20T12:43:57Z

Alright, that is a shame safari is causing such problems for us. I guess we will need to follow up with this later on if there is not a clear solution for this.

mountiny · 2022-01-20T12:50:09Z

Ok, I have created a follow-up issue, since I would say this has not been clearly stated before and we should not hold the payment of the linked issue on this regression. This is an edge case that will require additional treatment. #7334

rushatgabhane · 2022-01-20T17:08:05Z

Thanks!

ahmdshrif · 2022-01-20T18:20:23Z

thanks, mountiny rushatgabhane

OSBotify · 2022-01-21T00:15:30Z

🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ahmdshrif requested a review from a team as a code owner January 16, 2022 19:18

MelvinBot requested review from mountiny and rushatgabhane and removed request for a team January 16, 2022 19:19

mountiny reviewed Jan 16, 2022

View reviewed changes

rushatgabhane previously approved these changes Jan 16, 2022

View reviewed changes

mountiny previously approved these changes Jan 16, 2022

View reviewed changes

ahmdshrif dismissed stale reviews from mountiny and rushatgabhane via d197f49 January 16, 2022 23:51

ahmdshrif force-pushed the fix/chat-moves-on-new-message branch from 27ac6c9 to d197f49 Compare January 16, 2022 23:51

ahmdshrif requested review from mountiny and rushatgabhane January 16, 2022 23:57

mountiny previously approved these changes Jan 17, 2022

View reviewed changes

rushatgabhane previously approved these changes Jan 17, 2022

View reviewed changes

ahmdshrif closed this Jan 17, 2022

ahmdshrif force-pushed the fix/chat-moves-on-new-message branch from d197f49 to 74cf52f Compare January 17, 2022 02:12

add maintainVisibleContentPosition to FlatList

e5b98a9

ahmdshrif reopened this Jan 17, 2022

ahmdshrif dismissed stale reviews from rushatgabhane and mountiny via e5b98a9 January 17, 2022 02:13

rushatgabhane approved these changes Jan 17, 2022

View reviewed changes

ahmdshrif requested a review from mountiny January 17, 2022 03:56

mountiny approved these changes Jan 17, 2022

View reviewed changes

mountiny merged commit 2b7f6a7 into Expensify:main Jan 17, 2022

OSBotify mentioned this pull request Jan 18, 2022

Deploy Checklist: New Expensify 2022-01-18 #7297

Closed

56 tasks

This comment has been minimized.

Sign in to view

mountiny mentioned this pull request Jan 20, 2022

Chat moves up a bit when new message is received on mWeb Safari only #7334

Closed

botify mentioned this pull request Jan 20, 2022

[HOLD for payment 2022-01-27] Chat moves up a bit when new message is received - Reported by @K4tsuki #7145

Closed

ahmdshrif deleted the fix/chat-moves-on-new-message branch March 11, 2022 09:05

Santhosh-Sellavel mentioned this pull request Aug 10, 2022

[$2000] IOS - Chat - The Pay button in the money request is cut off if the request comes in an open chat #10283

Closed

Ollyws mentioned this pull request Dec 5, 2022

Chat scrolls after opening for the 2nd time reported by @thesahindia #12363

Closed

Uh oh!

Conversation

ahmdshrif commented Jan 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

rushatgabhane commented Jan 16, 2022

Uh oh!

ahmdshrif commented Jan 16, 2022

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Jan 16, 2022

Uh oh!

ahmdshrif commented Jan 16, 2022

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

ahmdshrif commented Jan 17, 2022

Uh oh!

mountiny commented Jan 17, 2022

Uh oh!

mountiny commented Jan 17, 2022

Uh oh!

OSBotify commented Jan 17, 2022

Uh oh!

OSBotify commented Jan 18, 2022

Uh oh!

kbecciv commented Jan 19, 2022 • edited by abecciv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmdshrif commented Jan 19, 2022

Platform:

Uh oh!

This comment has been minimized.

rushatgabhane commented Jan 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmdshrif commented Jan 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rushatgabhane commented Jan 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Jan 19, 2022

Uh oh!

ahmdshrif commented Jan 20, 2022

Uh oh!

mountiny commented Jan 20, 2022

Uh oh!

mountiny commented Jan 20, 2022

Uh oh!

rushatgabhane commented Jan 20, 2022

Uh oh!

ahmdshrif commented Jan 20, 2022

Uh oh!

OSBotify commented Jan 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

ahmdshrif commented Jan 16, 2022 •

edited

Loading

kbecciv commented Jan 19, 2022 •

edited by abecciv

Loading

rushatgabhane commented Jan 19, 2022 •

edited

Loading

ahmdshrif commented Jan 19, 2022 •

edited

Loading

rushatgabhane commented Jan 19, 2022 •

edited

Loading