Skip to content

Fix: background highlighting 🔦 issue for offline messages#7230

Merged
Beamanator merged 1 commit into
Expensify:mainfrom
parasharrajat:reportactionItem-gray
Jan 17, 2022
Merged

Fix: background highlighting 🔦 issue for offline messages#7230
Beamanator merged 1 commit into
Expensify:mainfrom
parasharrajat:reportactionItem-gray

Conversation

@parasharrajat

@parasharrajat parasharrajat commented Jan 14, 2022

Copy link
Copy Markdown
Member

Details

Fixed Issues

$ #7213

Tests | QA Steps

  1. Lunch the app
  2. Login with any account
  3. Use mobile data only, disable the Wifi
  4. Start sending the messages
  5. Enable Airplane mode and send more messages
  6. Disable the Airplane mode
  7. Message sent offline should not have a gray background color.
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

screen-2022-01-14_23.37.26.mp4

Mobile Web

Has the same effect as above.

iOS

Has the same effect as Android

Android

screen-2022-01-15_00.10.43.mp4

@parasharrajat parasharrajat marked this pull request as ready for review January 14, 2022 18:42
@parasharrajat parasharrajat requested a review from a team as a code owner January 14, 2022 18:42
@botify botify requested a review from Beamanator January 14, 2022 18:42
@MelvinBot MelvinBot removed the request for review from a team January 14, 2022 18:42
@Beamanator

Copy link
Copy Markdown
Contributor

Hmm I see how this fixes the issue where, after going from airplane mode back to normal (internet-connected) mode, the messages don't have a gray background anymore 👍

However, messages sent when in airplane mode should still have a gray background, right? I don't see that background in your videos 🤔

@parasharrajat

Copy link
Copy Markdown
Member Author

@Beamanator

However, messages sent when in airplane mode should still have a gray background, right? I don't see that background in your videos thinking

No, I was part of the implementation. I remember exactly, the design spec was to add gray text but not the background. #2526

@Beamanator

Copy link
Copy Markdown
Contributor

@parasharrajat nice, thanks for linking that 👍

@Beamanator Beamanator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Beamanator Beamanator merged commit 94d6b7b into Expensify:main Jan 17, 2022
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Beamanator in version: 1.1.30-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants