Skip to content

Quick cancel bugfix#7281

Merged
roryabraham merged 2 commits into
Expensify:mainfrom
kursat:job-7089
Jan 17, 2022
Merged

Quick cancel bugfix#7281
roryabraham merged 2 commits into
Expensify:mainfrom
kursat:job-7089

Conversation

@kursat

@kursat kursat commented Jan 17, 2022

Copy link
Copy Markdown
Contributor

Details

Fixed Issues

$ #7089

Tests

  • Verify that no errors appear in the JS console
  1. Edit a message.
  2. Write something and hit ESC or click cancel button within 1 second.
  3. See editing component doesn't re-opening.

QA Steps

  • Verify that no errors appear in the JS console
  1. Edit a message.
  2. Write something and hit ESC or click cancel button within 1 second.
  3. See editing component doesn't re-opening.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

quick-cancel-firefox.mp4

Mobile Web

quick-cancel-mobile-web.mp4

Desktop

iOS

Android

quick-cancel-android.mp4

@kursat kursat requested a review from a team as a code owner January 17, 2022 17:59
@MelvinBot MelvinBot requested review from roryabraham and removed request for a team January 17, 2022 17:59
@roryabraham

Copy link
Copy Markdown
Contributor

@kursat Are you unable to test on iOS/desktop?

@roryabraham

Copy link
Copy Markdown
Contributor

I verified this fix works well on web + desktop, testing on iOS next.

@roryabraham

Copy link
Copy Markdown
Contributor

Verified this fix on iOS as well ✅

@roryabraham roryabraham merged commit 7220b25 into Expensify:main Jan 17, 2022
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@kursat

kursat commented Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

@roryabraham, I am renting from macincloud when I need it. I was going to add ios and desktop screen recordings today. Thank you very much for verifying.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.30-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants