Make About footer links accessible

[elemdos]

Details

Opened in place of a previous PR for code-signing purposes

Fixed Issues

$ #5082

Tests

1. Open Settings screen
2. Click 'About'
3. Tab through About options
4. Verify footer links (Terms of Service, Privacy Policy) focus when tabbed

QA Steps

1. Open Settings screen
2. Click 'About'
3. Tab through About options
4. Verify footer links (Terms of Service, Privacy Policy) focus when tabbed

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Web.mov

Mobile Web

mobileweblinkopens.mov

Desktop

desktoplinks.mov

iOS

ios.mov

Android

androidscreen.mov

[marcochavezf]

Hi @MateoMorris! Thank you for pushing this PR, the solution looks good but I noticed when I click on the footer links in Web the links are opened in the same tab vs in a new one (which is the default behavior). Thoughts?

[elemdos]

@marcochavezf sounds like it would be best to have them open in a new tab, should I go ahead and do that?

[marcochavezf]

@marcochavezf sounds like it would be best to have them open in a new tab, should I go ahead and do that?

@MateoMorris yeah please, because that is what's happening currently in the production app and it's a bit jarring for the user to navigate back to the app when the ToS o privacy links are opened in the same tab 🙇🏽‍♂️

[elemdos]

@marcochavezf okay ready - it's opening in a new tab now. I had to use accessibilityRole to make the link accessible (instead of making it an anchor tag) which isn't ideal, but the only clear way to make the link open in a new tab.

[marcochavezf]

@MateoMorris Thanks for addressing that change!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @marcochavezf in version: 1.1.30-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅