fix: bump nmstate-console-plugin release-4.17/4.18/4.20 to tectonic-console-builder-v29 - #82053
Open
ronlavi2412 wants to merge 1 commit into
Open
fix: bump nmstate-console-plugin release-4.17/4.18/4.20 to tectonic-console-builder-v29#82053ronlavi2412 wants to merge 1 commit into
ronlavi2412 wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (6)
WalkthroughThe release configurations for OpenShift and privileged OpenShift nmstate console plugins update their build-root image stream tag from ChangesNmstate console builder image update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
This was referenced Jul 17, 2026
…onsole-builder-v29 Standardizes all remaining nmstate-console-plugin release branches to the current CI builder. Branches release-4.19, 4.21, 4.22, and main already use v29; this aligns 4.17, 4.18, and 4.20. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
ronlavi2412
force-pushed
the
fix/nmstate-ci-builder-v29
branch
from
July 17, 2026 03:09
a849847 to
5d12174
Compare
Contributor
|
@ronlavi2412: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danilo-gemoli, Parthivk100, ronlavi2412 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tectonic-console-builder-v24→tectonic-console-builder-v29fornmstate-console-pluginCI configs onrelease-4.17,release-4.18, andrelease-4.20(bothopenshift/andopenshift-priv/namespaces)Context
release-4.19,release-4.21,release-4.22, andmainalready usev29. The remaining branches (4.17,4.18,4.20) are still onv24— this PR standardizes all active branches to the current builder.The root issue: #78488 (networking-console-plugin yarn→npm migration) accidentally bumped
nmstate-console-plugin release-4.19fromv24→v29, causing its CI to break (Chrome not found inv29). Rather than reverting, this PR completes the migration intentionally for all remaining branches.release-4.17,release-4.18, andrelease-4.20useyarn run cypressintest-prow-e2e.sh, which will break when those branches move tov29(same as the currentrelease-4.19failure). The companionpackage.jsonfixes must merge before this PR:release-4.20release-4.18release-4.17Immediate CI fix (already active)
release-4.19is already broken — fixed by openshift/nmstate-console-plugin#263 (which this PR is not a blocker for).All companion PRs (nmstate-console-plugin)
release-4.19release-4.21release-4.22mainrelease-4.20release-4.18release-4.17Test plan
release-4.17,release-4.18,release-4.20passes after this merges🤖 Generated with Claude Code
Summary by CodeRabbit
nmstate-console-pluginCI builds for release branches 4.17, 4.18, and 4.20 in bothopenshiftandopenshift-privnamespaces to usetectonic-console-builder-v29instead ofv24.v29does not include Chrome; CI validation should follow those prerequisite changes.