Migrate networking-console-plugin 4.19 branch from yarn to npm - #78488
Conversation
WalkthroughTwo CI configuration files for console plugins update their build root image tag to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift/networking-console-plugin/openshift-networking-console-plugin-release-4.19.yaml (1)
36-36: Prefernpm ciovernpm installin CI test steps.For CI reproducibility, switch these installs to
npm ci(as already done inci-operator/config/openshift/networking-console-plugin/openshift-networking-console-plugin-main.yaml). This avoids drift and enforces lockfile fidelity.Proposed change
- commands: npm install && npm run lint && npm run build + commands: npm ci && npm run lint && npm run build ... - npm install && npm run i18n + npm ci && npm run i18nPlease verify the release-4.19 source branch has a committed
package-lock.jsonsonpm ciis guaranteed to work.Also applies to: 44-44
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/config/openshift/networking-console-plugin/openshift-networking-console-plugin-release-4.19.yaml` at line 36, The CI step currently uses the non-deterministic install command shown as "commands: npm install && npm run lint && npm run build"; change it to use "npm ci" instead of "npm install" to enforce lockfile fidelity (i.e., "commands: npm ci && npm run lint && npm run build") and ensure the release-4.19 source branch contains a committed package-lock.json so npm ci will succeed; update the command string where it appears and verify the lockfile exists on the release branch before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@ci-operator/config/openshift/networking-console-plugin/openshift-networking-console-plugin-release-4.19.yaml`:
- Line 36: The CI step currently uses the non-deterministic install command
shown as "commands: npm install && npm run lint && npm run build"; change it to
use "npm ci" instead of "npm install" to enforce lockfile fidelity (i.e.,
"commands: npm ci && npm run lint && npm run build") and ensure the release-4.19
source branch contains a committed package-lock.json so npm ci will succeed;
update the command string where it appears and verify the lockfile exists on the
release branch before merging.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 3897853b-9a16-4aa9-9bcd-5b6cef64177b
📒 Files selected for processing (2)
ci-operator/config/openshift/networking-console-plugin/openshift-networking-console-plugin-release-4.19.yamlci-operator/config/openshift/nmstate-console-plugin/openshift-nmstate-console-plugin-release-4.19.yaml
|
/pj-rehearse ack |
|
@pcbailey: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
9e87e2d to
a6a51e0
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift/networking-console-plugin/openshift-networking-console-plugin-release-4.19.yaml (1)
36-36: Usenpm ciinstead ofnpm installin CI commands.Lines 36 and 44 use
npm install, which is less reproducible and typically slower in CI pipelines.npm cienforces lockfile-based dependency installation, providing better consistency and performance. Newer versions of this configuration (4.22+, 4.23, 5.0, 5.1, and main) already follow this pattern.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/config/openshift/networking-console-plugin/openshift-networking-console-plugin-release-4.19.yaml` at line 36, Replace the non-reproducible npm install usage in the CI step with npm ci: update the commands entry that currently reads "commands: npm install && npm run lint && npm run build" (and the similar occurrence at the later commands line) to use "npm ci && npm run lint && npm run build" so the job uses lockfile-based, faster, and reproducible installs in CI.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@ci-operator/config/openshift/networking-console-plugin/openshift-networking-console-plugin-release-4.19.yaml`:
- Line 36: Replace the non-reproducible npm install usage in the CI step with
npm ci: update the commands entry that currently reads "commands: npm install &&
npm run lint && npm run build" (and the similar occurrence at the later commands
line) to use "npm ci && npm run lint && npm run build" so the job uses
lockfile-based, faster, and reproducible installs in CI.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 1b31e7cc-978c-4640-8fb4-6d247f48c251
⛔ Files ignored due to path filters (216)
ci-operator/jobs/3scale-qe/3scale-deploy/3scale-qe-3scale-deploy-main-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/3scale-qe/3scale-deploy/3scale-qe-3scale-deploy-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/Azure/ARO-HCP/Azure-ARO-HCP-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/Azure/ARO-HCP/Azure-ARO-HCP-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/Azure/ARO-RP/Azure-ARO-RP-master-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/Azure/ARO-RP/Azure-ARO-RP-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/CSPI-QE/interop-ocp-watcher-bot/CSPI-QE-interop-ocp-watcher-bot-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/CSPI-QE/interop-ocp-watcher-bot/CSPI-QE-interop-ocp-watcher-bot-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ComplianceAsCode/compliance-operator/ComplianceAsCode-compliance-operator-1.6-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ComplianceAsCode/compliance-operator/ComplianceAsCode-compliance-operator-1.6-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ComplianceAsCode/compliance-operator/ComplianceAsCode-compliance-operator-1.7-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ComplianceAsCode/compliance-operator/ComplianceAsCode-compliance-operator-1.7-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ComplianceAsCode/compliance-operator/ComplianceAsCode-compliance-operator-master-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ComplianceAsCode/compliance-operator/ComplianceAsCode-compliance-operator-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ComplianceAsCode/content/ComplianceAsCode-content-master-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ComplianceAsCode/content/ComplianceAsCode-content-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/RedHatQE/firewatch/RedHatQE-firewatch-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/RedHatQE/firewatch/RedHatQE-firewatch-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/RedHatQE/interop-aws-reporter/RedHatQE-interop-aws-reporter-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/RedHatQE/interop-testing/RedHatQE-interop-testing-cnv-4.18-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/RedHatQE/interop-testing/RedHatQE-interop-testing-cnv-4.18-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/RedHatQE/interop-testing/RedHatQE-interop-testing-master-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/RedHatQE/interop-testing/RedHatQE-interop-testing-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/log-file-metric-exporter/ViaQ-log-file-metric-exporter-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/log-file-metric-exporter/ViaQ-log-file-metric-exporter-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/log-file-metric-exporter/ViaQ-log-file-metric-exporter-release-5.8-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/log-file-metric-exporter/ViaQ-log-file-metric-exporter-release-5.8-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/log-file-metric-exporter/ViaQ-log-file-metric-exporter-release-5.9-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/log-file-metric-exporter/ViaQ-log-file-metric-exporter-release-5.9-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/log-file-metric-exporter/ViaQ-log-file-metric-exporter-release-6.0-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/log-file-metric-exporter/ViaQ-log-file-metric-exporter-release-6.0-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/log-file-metric-exporter/ViaQ-log-file-metric-exporter-release-v1.0-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/log-file-metric-exporter/ViaQ-log-file-metric-exporter-release-v1.0-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/log-file-metric-exporter/ViaQ-log-file-metric-exporter-release-v1.1-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/log-file-metric-exporter/ViaQ-log-file-metric-exporter-release-v1.1-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/logging-fluentd/ViaQ-logging-fluentd-v1.16.x-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/logging-fluentd/ViaQ-logging-fluentd-v1.16.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/logging-kibana/ViaQ-logging-kibana-openshift-logging-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/logging-kibana/ViaQ-logging-kibana-openshift-logging-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/vector/ViaQ-vector-release-5.8-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/vector/ViaQ-vector-release-5.8-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/vector/ViaQ-vector-release-5.9-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/vector/ViaQ-vector-release-5.9-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/vector/ViaQ-vector-v0.37.1-rh-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/vector/ViaQ-vector-v0.37.1-rh-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/vector/ViaQ-vector-v0.47.0-rh-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/vector/ViaQ-vector-v0.47.0-rh-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/vector/ViaQ-vector-v0.50.0-rh-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/vector/ViaQ-vector-v0.50.0-rh-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/vector/ViaQ-vector-v0.54.0-rh-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ViaQ/vector/ViaQ-vector-v0.54.0-rh-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/app-sre/deployment-validation-operator/app-sre-deployment-validation-operator-master-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/app-sre/deployment-validation-operator/app-sre-deployment-validation-operator-master-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/app-sre/deployment-validation-operator/app-sre-deployment-validation-operator-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/backube/volsync/backube-volsync-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/backube/volsync/backube-volsync-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/codeready-toolchain/workload-analyzer/codeready-toolchain-workload-analyzer-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/coreos/coreos-assembler/coreos-coreos-assembler-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/coreos/coreos-assembler/coreos-coreos-assembler-rhcos-4.10-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/coreos/coreos-assembler/coreos-coreos-assembler-rhcos-4.11-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/coreos/coreos-assembler/coreos-coreos-assembler-rhcos-4.12-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/coreos/coreos-assembler/coreos-coreos-assembler-rhcos-4.13-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/coreos/coreos-assembler/coreos-coreos-assembler-rhcos-4.14-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/coreos/coreos-assembler/coreos-coreos-assembler-rhcos-4.15-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/coreos/coreos-assembler/coreos-coreos-assembler-rhcos-4.16-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/coreos/coreos-assembler/coreos-coreos-assembler-rhcos-4.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/coreos/coreos-assembler/coreos-coreos-assembler-rhcos-4.18-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/coreos/coreos-assembler/coreos-coreos-assembler-rhcos-4.19-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/coreos/coreos-assembler/coreos-coreos-assembler-rhcos-4.8-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/coreos/coreos-assembler/coreos-coreos-assembler-rhcos-4.9-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/coreos/coreos-assembler/coreos-coreos-assembler-rhel-9.6-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/crc/crc-org-crc-crc-ng-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/crc/crc-org-crc-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-4.7-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-4.8-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-4.9-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-podman-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-release-4.11-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-release-4.12-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-release-4.13-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-release-4.14-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-release-4.15-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-release-4.16-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-release-4.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-release-4.18-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-release-4.19-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-release-4.20-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-release-4.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/crc-org/snc/crc-org-snc-release-4.22-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-release-1.13-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-release-1.14-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-release-1.16-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-release-1.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-release-1.18-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-release-1.19-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-release-1.20-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-release-1.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-release-1.22-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-release-1.23-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-release-1.24-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-release-1.25-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/devfile/devworkspace-operator/devfile-devworkspace-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/devfile/integration-tests/devfile-integration-tests-main-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/devfile/integration-tests/devfile-integration-tests-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/devfile/integration-tests/devfile-integration-tests-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/devfile/registry-operator/devfile-registry-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/devfile/registry/devfile-registry-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/eclipse-che/che-dashboard/eclipse-che-che-dashboard-7.113.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/eclipse-che/che-dashboard/eclipse-che-che-dashboard-7.114.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/eclipse-che/che-dashboard/eclipse-che-che-dashboard-7.115.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/eclipse-che/che-dashboard/eclipse-che-che-dashboard-7.116.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/eclipse-che/che-dashboard/eclipse-che-che-dashboard-7.117.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/eclipse-che/che-dashboard/eclipse-che-che-dashboard-7.118.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/eclipse-che/che-dashboard/eclipse-che-che-dashboard-7.119.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/eclipse-che/che-dashboard/eclipse-che-che-dashboard-7.120.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/eclipse-che/che-dashboard/eclipse-che-che-dashboard-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/eclipse-che/che-plugin-registry/eclipse-che-che-plugin-registry-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/fleetshift/fleetshift-user-interface/fleetshift-fleetshift-user-interface-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/fleetshift/fleetshift-user-interface/fleetshift-fleetshift-user-interface-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/identitatem/dex-operator/identitatem-dex-operator-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/identitatem/dex-operator/identitatem-dex-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/identitatem/dex-operator/identitatem-dex-operator-stable-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/identitatem/dex-operator/identitatem-dex-operator-stable-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/identitatem/idp-mgmt-operator/identitatem-idp-mgmt-operator-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/identitatem/idp-mgmt-operator/identitatem-idp-mgmt-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/identitatem/idp-mgmt-operator/identitatem-idp-mgmt-operator-stable-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/identitatem/idp-mgmt-operator/identitatem-idp-mgmt-operator-stable-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/identitatem/idp-mgmt-operator/identitatem-idp-mgmt-operator-test-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/identitatem/idp-mgmt-operator/identitatem-idp-mgmt-operator-test-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/infinispan/infinispan-operator/infinispan-infinispan-operator-stable-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/infinispan/infinispan-operator/infinispan-infinispan-operator-stable-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/application-monitoring-operator/integr8ly-application-monitoring-operator-master-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/application-monitoring-operator/integr8ly-application-monitoring-operator-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/cloud-resource-operator/integr8ly-cloud-resource-operator-master-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/cloud-resource-operator/integr8ly-cloud-resource-operator-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/cloud-resource-operator/integr8ly-cloud-resource-operator-mgdapi-3425-gcp-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/cloud-resource-operator/integr8ly-cloud-resource-operator-mgdapi-3425-gcp-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/delorean/integr8ly-delorean-master-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/delorean/integr8ly-delorean-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/integreatly-operator/integr8ly-integreatly-operator-master-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/integreatly-operator/integr8ly-integreatly-operator-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/integreatly-operator/integr8ly-integreatly-operator-mgdapi-1595-cluster-scoped-3scale-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/integreatly-operator/integr8ly-integreatly-operator-mgdapi-1595-cluster-scoped-3scale-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/integreatly-operator/integr8ly-integreatly-operator-mgdapi-3425-gcp-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/integreatly-operator/integr8ly-integreatly-operator-mgdapi-3425-gcp-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/integreatly-operator/integr8ly-integreatly-operator-mgdapi-3551-autoscaling-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/integreatly-operator/integr8ly-integreatly-operator-mgdapi-3551-autoscaling-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/integreatly-operator/integr8ly-integreatly-operator-mgdapi-5727-obo-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/integreatly-operator/integr8ly-integreatly-operator-mgdapi-5727-obo-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/integreatly-operator/integr8ly-integreatly-operator-rhoam-release-v1.33-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/integreatly-operator/integr8ly-integreatly-operator-rhoam-release-v1.33-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/workload-web-app/integr8ly-workload-web-app-master-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/integr8ly/workload-web-app/integr8ly-workload-web-app-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/jboss-eap-qe/openshift-eap-tests/jboss-eap-qe-openshift-eap-tests-pit-7.4.x-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/jboss-eap-qe/openshift-eap-tests/jboss-eap-qe-openshift-eap-tests-pit-7.4.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/jboss-fuse/camel-k-test-container/jboss-fuse-camel-k-test-container-main-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/jboss-fuse/camel-k-test-container/jboss-fuse-camel-k-test-container-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/jianzhangbjz/learn-operator/jianzhangbjz-learn-operator-master-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/jianzhangbjz/learn-operator/jianzhangbjz-learn-operator-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v1.0.x-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v1.0.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v1.1.x-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v1.1.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v1.2.x-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v1.2.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v1.3.x-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v1.3.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v1.4.x-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v1.4.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v7.10.x-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v7.10.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v7.11.x-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v7.11.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v7.12.x-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v7.12.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v7.13.x-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v7.13.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v7.8.x-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v7.8.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v7.9.x-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-operator/kiegroup-kie-cloud-operator-release-v7.9.x-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-tests-container/kiegroup-kie-cloud-tests-container-main-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kiegroup/kie-cloud-tests-container/kiegroup-kie-cloud-tests-container-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/konflux-ci/e2e-tests/konflux-ci-e2e-tests-main-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/konflux-ci/e2e-tests/konflux-ci-e2e-tests-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/konflux-ci/e2e-tests/konflux-ci-e2e-tests-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/konveyor/tackle-ui-tests/konveyor-tackle-ui-tests-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/konveyor/tackle-ui-tests/konveyor-tackle-ui-tests-mta_7.2.0-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/konveyor/tackle-ui-tests/konveyor-tackle-ui-tests-mta_7.2.0-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/konveyor/tackle-ui-tests/konveyor-tackle-ui-tests-mta_8.0.0-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/konveyor/tackle-ui-tests/konveyor-tackle-ui-tests-mta_8.0.0-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/konveyor/tackle-ui-tests/konveyor-tackle-ui-tests-release-0.6-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/konveyor/tackle-ui-tests/konveyor-tackle-ui-tests-release-0.6-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/konveyor/tackle-ui-tests/konveyor-tackle-ui-tests-release-0.7-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/konveyor/tackle-ui-tests/konveyor-tackle-ui-tests-release-0.7-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/konveyor/tackle2-ui/konveyor-tackle2-ui-release-0.8-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/konveyor/tackle2-ui/konveyor-tackle2-ui-release-0.8-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kube-reporting/ghostunnel/kube-reporting-ghostunnel-master-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kube-reporting/ghostunnel/kube-reporting-ghostunnel-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kube-reporting/ghostunnel/kube-reporting-ghostunnel-release-4.10-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kube-reporting/ghostunnel/kube-reporting-ghostunnel-release-4.10-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kube-reporting/ghostunnel/kube-reporting-ghostunnel-release-4.11-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kube-reporting/ghostunnel/kube-reporting-ghostunnel-release-4.11-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kube-reporting/ghostunnel/kube-reporting-ghostunnel-release-4.12-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kube-reporting/ghostunnel/kube-reporting-ghostunnel-release-4.12-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kube-reporting/ghostunnel/kube-reporting-ghostunnel-release-4.13-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kube-reporting/ghostunnel/kube-reporting-ghostunnel-release-4.13-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kube-reporting/ghostunnel/kube-reporting-ghostunnel-release-4.14-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kube-reporting/ghostunnel/kube-reporting-ghostunnel-release-4.14-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kube-reporting/ghostunnel/kube-reporting-ghostunnel-release-4.15-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/kube-reporting/ghostunnel/kube-reporting-ghostunnel-release-4.15-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (2)
ci-operator/config/openshift/networking-console-plugin/openshift-networking-console-plugin-release-4.19.yamlci-operator/config/openshift/nmstate-console-plugin/openshift-nmstate-console-plugin-release-4.19.yaml
✅ Files skipped from review due to trivial changes (1)
- ci-operator/config/openshift/nmstate-console-plugin/openshift-nmstate-console-plugin-release-4.19.yaml
a6a51e0 to
9e87e2d
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/retest-required |
|
@pcbailey: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@upalatucci: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
build_rootimage tag totectonic-console-builder-v29fornetworking-console-pluginrelease-4.19 CI configurationsyarncommands withnpmequivalents in lint and i18n test steps as part of the yarn to npm migrationDetails
The networking-console-plugin repository is migrating from yarn to npm. This PR updates the CI configurations to:
tectonic-console-builder-v29base image which includes npm supportyarn install->npm install,yarn run lint->npm run lint,yarn build->npm run build,yarn i18n->npm i18n)Summary by CodeRabbit