Skip to content

fix: use electron browser in cypress [release-4.21] - #264

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.21from
ronlavi2412:fix/cypress-electron-release-4.21
Jul 17, 2026
Merged

fix: use electron browser in cypress [release-4.21]#264
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.21from
ronlavi2412:fix/cypress-electron-release-4.21

Conversation

@ronlavi2412

@ronlavi2412 ronlavi2412 commented Jul 17, 2026

Copy link
Copy Markdown

Summary

  • Change cypress run --browser chromecypress run --browser electron in package.json (developer consistency fix)

Why CI is not broken on this branch

On release-4.21, test-prow-e2e.sh calls npm run test-cypress-headless — not yarn run cypress. The test-cypress-headless script already defaults to electron:

node ... cypress run --env openshift=true --browser ${BRIDGE_E2E_BROWSER_NAME:=electron}

So the CI pipeline on this branch is not affected by the Chrome absence in tectonic-console-builder-v29.

Why this PR is still useful

The cypress script (used for local development: yarn/npm run cypress) still hardcodes --browser chrome, which will fail on any machine without Chrome. This PR makes the local developer experience consistent with what CI actually runs.

Companion PRs

CI builder standardization (openshift/release): openshift/release#82053

This series (all branches):

Branch PR Role
release-4.19 #263 Urgent — fixes active CI failure
release-4.21 #264 Consistency — CI already uses electron
release-4.22 #265 Consistency — CI already uses electron
main #266 Consistency — CI already uses electron
release-4.20 #267 Prerequisite — must merge before openshift/release#82053
release-4.18 #268 Prerequisite — must merge before openshift/release#82053
release-4.17 #269 Prerequisite — must merge before openshift/release#82053

Test plan

  • npm run cypress launches Cypress under Electron locally

🤖 Generated with Claude Code

tectonic-console-builder-v29 does not ship Chrome; electron is always
bundled with Cypress and provides equivalent Chromium-based rendering.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1e2daa08-2c52-4ea4-a663-e62266d48ce0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from batyana and upalatucci July 17, 2026 02:53
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ronlavi2412

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown

@ronlavi2412: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Parthivk100

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit b825e32 into openshift:release-4.21 Jul 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants