fix: use electron browser in cypress [release-4.21] - #264
Conversation
tectonic-console-builder-v29 does not ship Chrome; electron is always bundled with Cypress and provides equivalent Chromium-based rendering. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ronlavi2412 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ronlavi2412: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
b825e32
into
openshift:release-4.21
Summary
cypress run --browser chrome→cypress run --browser electroninpackage.json(developer consistency fix)Why CI is not broken on this branch
On
release-4.21,test-prow-e2e.shcallsnpm run test-cypress-headless— notyarn run cypress. Thetest-cypress-headlessscript already defaults toelectron:So the CI pipeline on this branch is not affected by the Chrome absence in
tectonic-console-builder-v29.Why this PR is still useful
The
cypressscript (used for local development:yarn/npm run cypress) still hardcodes--browser chrome, which will fail on any machine without Chrome. This PR makes the local developer experience consistent with what CI actually runs.Companion PRs
CI builder standardization (openshift/release): openshift/release#82053
This series (all branches):
release-4.19release-4.21release-4.22mainrelease-4.20release-4.18release-4.17Test plan
npm run cypresslaunches Cypress under Electron locally🤖 Generated with Claude Code