Skip to content

fix: use electron browser in cypress [release-4.18] - #268

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.18from
ronlavi2412:fix/cypress-electron-release-4.18
Jul 17, 2026
Merged

fix: use electron browser in cypress [release-4.18]#268
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.18from
ronlavi2412:fix/cypress-electron-release-4.18

Conversation

@ronlavi2412

@ronlavi2412 ronlavi2412 commented Jul 17, 2026

Copy link
Copy Markdown

Summary

  • Change cypress run --browser chromecypress run --browser electron in package.json

Why this is a prerequisite

On release-4.18, test-prow-e2e.sh calls yarn run cypress, which maps to the cypress npm script. CI currently works because this branch still uses tectonic-console-builder-v24, which ships Chrome.

However, openshift/release#82053 will bump this branch to tectonic-console-builder-v29 (which does not ship Chrome). This PR must merge before openshift/release#82053 — otherwise CI on release-4.18 will fail with the same error already seen on release-4.19:

Browser: chrome was not found on your system or is not supported by Cypress.
Available browsers found on your system are:
 - electron

Background

release-4.19 is currently broken because it was accidentally bumped to v29 by openshift/release#78488 (a networking-console-plugin migration that inadvertently touched nmstate CI config). openshift/release#82053 standardizes all remaining branches to v29 intentionally. This fix ensures release-4.18 is ready.

Companion PRs

CI builder standardization (openshift/release): openshift/release#82053

This series (all branches):

Branch PR Role
release-4.19 #263 Urgent — fixes active CI failure
release-4.21 #264 Consistency — CI already uses electron
release-4.22 #265 Consistency — CI already uses electron
main #266 Consistency — CI already uses electron
release-4.20 #267 Prerequisite — must merge before openshift/release#82053
release-4.18 #268 Prerequisite — must merge before openshift/release#82053
release-4.17 #269 Prerequisite — must merge before openshift/release#82053

Test plan

🤖 Generated with Claude Code

tectonic-console-builder-v29 does not ship Chrome; electron is always
bundled with Cypress and provides equivalent Chromium-based rendering.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d37ae4fe-39d0-4b42-a5e9-19f40ee7f7f7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown

@ronlavi2412: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Parthivk100 Parthivk100 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Parthivk100, ronlavi2412

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Parthivk100,ronlavi2412]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 9f93ea4 into openshift:release-4.18 Jul 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants