Skip to content

fix: use electron browser in cypress [release-4.19] - #263

Merged
ronlavi2412 merged 1 commit into
openshift:release-4.19from
ronlavi2412:fix/cypress-electron-browser
Jul 17, 2026
Merged

fix: use electron browser in cypress [release-4.19]#263
ronlavi2412 merged 1 commit into
openshift:release-4.19from
ronlavi2412:fix/cypress-electron-browser

Conversation

@ronlavi2412

@ronlavi2412 ronlavi2412 commented Jul 17, 2026

Copy link
Copy Markdown

Summary

  • Change cypress run --browser chromecypress run --browser electron in package.json

Why this branch is broken

test-prow-e2e.sh on release-4.19 calls yarn run cypress, which maps directly to the cypress npm script. That script was passing --browser chrome, but tectonic-console-builder-v29 (the current CI builder for this branch) does not ship Chrome — only Electron is bundled with Cypress.

Failing Prow run: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_nmstate-console-plugin/245/pull-ci-openshift-nmstate-console-plugin-release-4.19-e2e-tests/2077793896619839488

Browser: chrome was not found on your system or is not supported by Cypress.
Available browsers found on your system are:
 - electron

Root cause

openshift/release#78488 (networking-console-plugin yarn→npm migration) accidentally bumped the CI builder for nmstate-console-plugin release-4.19 from tectonic-console-builder-v24 (which ships Chrome) to v29 (which does not). nmstate-console-plugin was never part of that migration.

Rather than reverting, this PR fixes the cypress script to use electron, which is always bundled with Cypress and uses the same Chromium engine.

Companion PRs

CI builder standardization (openshift/release): openshift/release#82053
Bumps remaining branches (release-4.17, release-4.18, release-4.20) from v24 → v29.

This series (all branches):

Branch PR Role
release-4.19 #263 Urgent — fixes active CI failure
release-4.21 #264 Consistency — CI already uses electron
release-4.22 #265 Consistency — CI already uses electron
main #266 Consistency — CI already uses electron
release-4.20 #267 Prerequisite — must merge before openshift/release#82053
release-4.18 #268 Prerequisite — must merge before openshift/release#82053
release-4.17 #269 Prerequisite — must merge before openshift/release#82053

Test plan

  • Prow e2e job passes on release-4.19

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 580419f6-bcd9-4e10-b3de-b70d915c91ae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

tectonic-console-builder-v29 does not ship Chrome; electron is always
bundled with Cypress and provides equivalent Chromium-based rendering.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@ronlavi2412
ronlavi2412 force-pushed the fix/cypress-electron-browser branch from e27b5be to 1925dd2 Compare July 17, 2026 03:01
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown

@ronlavi2412: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Parthivk100

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2026
@Parthivk100

Copy link
Copy Markdown

/approve

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Parthivk100, ronlavi2412
Once this PR has been reviewed and has the lgtm label, please assign yaacov for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ronlavi2412
ronlavi2412 merged commit 3679d74 into openshift:release-4.19 Jul 17, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants