fix: use electron browser in cypress [release-4.19] - #263
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tectonic-console-builder-v29 does not ship Chrome; electron is always bundled with Cypress and provides equivalent Chromium-based rendering. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
e27b5be to
1925dd2
Compare
|
@ronlavi2412: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Parthivk100, ronlavi2412 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary
cypress run --browser chrome→cypress run --browser electroninpackage.jsonWhy this branch is broken
test-prow-e2e.shonrelease-4.19callsyarn run cypress, which maps directly to thecypressnpm script. That script was passing--browser chrome, buttectonic-console-builder-v29(the current CI builder for this branch) does not ship Chrome — only Electron is bundled with Cypress.Failing Prow run: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_nmstate-console-plugin/245/pull-ci-openshift-nmstate-console-plugin-release-4.19-e2e-tests/2077793896619839488
Root cause
openshift/release#78488 (networking-console-plugin yarn→npm migration) accidentally bumped the CI builder for
nmstate-console-plugin release-4.19fromtectonic-console-builder-v24(which ships Chrome) tov29(which does not).nmstate-console-pluginwas never part of that migration.Rather than reverting, this PR fixes the
cypressscript to useelectron, which is always bundled with Cypress and uses the same Chromium engine.Companion PRs
CI builder standardization (openshift/release): openshift/release#82053
Bumps remaining branches (
release-4.17,release-4.18,release-4.20) from v24 → v29.This series (all branches):
release-4.19release-4.21release-4.22mainrelease-4.20release-4.18release-4.17Test plan
release-4.19🤖 Generated with Claude Code