fix: use electron browser in cypress [release-4.20] - #267
Conversation
tectonic-console-builder-v29 does not ship Chrome; electron is always bundled with Cypress and provides equivalent Chromium-based rendering. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ronlavi2412 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ronlavi2412: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
a631bdd
into
openshift:release-4.20
Summary
cypress run --browser chrome→cypress run --browser electroninpackage.jsonWhy this is a prerequisite
On
release-4.20,test-prow-e2e.shcallsyarn run cypress, which maps to thecypressnpm script. CI currently works because this branch still usestectonic-console-builder-v24, which ships Chrome.However, openshift/release#82053 will bump this branch to
tectonic-console-builder-v29(which does not ship Chrome). This PR must merge before openshift/release#82053 — otherwise CI onrelease-4.20will fail with the same error already seen onrelease-4.19:Background
release-4.19is currently broken because it was accidentally bumped tov29by openshift/release#78488 (a networking-console-plugin migration that inadvertently touched nmstate CI config). openshift/release#82053 standardizes all remaining branches tov29intentionally. This fix ensuresrelease-4.20is ready.Companion PRs
CI builder standardization (openshift/release): openshift/release#82053
This series (all branches):
release-4.19release-4.21release-4.22mainrelease-4.20release-4.18release-4.17Test plan
release-4.20continues to pass after fix: bump nmstate-console-plugin release-4.17/4.18/4.20 to tectonic-console-builder-v29 release#82053 merges🤖 Generated with Claude Code