feat: add config.json envelopeType support#329
Merged
chloeyin merged 1 commit intonotaryproject:cosefrom Sep 6, 2022
Merged
Conversation
JeyJeyGao
force-pushed
the
junjiegao/config_add_envelopeType
branch
from
e721a5b to
b988b6b
Compare
chloeyin
reviewed
Sep 6, 2022
JeyJeyGao
force-pushed
the
junjiegao/config_add_envelopeType
branch
from
b988b6b to
ad3f5d0
Compare
chloeyin
reviewed
Sep 6, 2022
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
force-pushed
the
junjiegao/config_add_envelopeType
branch
from
ad3f5d0 to
6c26550
Compare
chloeyin
approved these changes
Sep 6, 2022
chloeyin
approved these changes
Sep 6, 2022
patrickzheng200
added a commit
that referenced
this pull request
Sep 13, 2022
* notation cert add AND notation cert list for trust store Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * add config.json envelopeType support (#329) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com> * added notation cert show command Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation cert add Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation cert show Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added notation cert delete Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added test certificates Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * feat: write envelopeType default value to config.json (#330) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com> * updated CLI for trust store Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation cert commands with system level FS Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated to use notation-go dev-rc.1 branch Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation-go Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added cert_test.go for trust store Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated failure messages of notation cert commands Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
chloeyin
added a commit
that referenced
this pull request
Sep 13, 2022
* add config.json envelopeType support (#329) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com> * feat: write envelopeType default value to config.json (#330) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com> * feat: update to go 1.19 (#327) (#336) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: zaihaoyin <zaihaoyin@microsoft.com>
patrickzheng200
added a commit
that referenced
this pull request
Sep 14, 2022
* notation cert add AND notation cert list for trust store Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * add config.json envelopeType support (#329) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com> * added notation cert show command Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation cert add Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation cert show Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added notation cert delete Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added test certificates Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * feat: write envelopeType default value to config.json (#330) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com> * updated CLI for trust store Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation cert commands with system level FS Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated to use notation-go dev-rc.1 branch Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation-go Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added cert_test.go for trust store Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated failure messages of notation cert commands Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added notation cert generate-test command Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
patrickzheng200
pushed a commit
that referenced
this pull request
Sep 19, 2022
* notation cert add AND notation cert list for trust store Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * add config.json envelopeType support (#329) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com> * added notation cert show command Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation cert add Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation cert show Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added notation cert delete Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added test certificates Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * feat: write envelopeType default value to config.json (#330) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com> * updated CLI for trust store Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation cert commands with system level FS Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated to use notation-go dev-rc.1 branch Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation-go Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added cert_test.go for trust store Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated failure messages of notation cert commands Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added notation cert generate-test command Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated trust store implementation Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update per code review Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update per code review Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
patrickzheng200
pushed a commit
that referenced
this pull request
Sep 23, 2022
* notation cert add AND notation cert list for trust store Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * add config.json envelopeType support (#329) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com> * added notation cert show command Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation cert add Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation cert show Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added notation cert delete Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added test certificates Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * feat: write envelopeType default value to config.json (#330) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com> * updated CLI for trust store Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation cert commands with system level FS Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated to use notation-go dev-rc.1 branch Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * feat: update to go 1.19 (#327) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> * updated notation-go Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added cert_test.go for trust store Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated failure messages of notation cert commands Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added notation cert generate-test command Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated trust store implementation Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update per code review Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update per code review Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated trust store implementation Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * added confirmation to notation cert delete command Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated generate-test to self-signed cert Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated generate-test to self-signed cert Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated generate-test to self-signed cert Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated notation cert CLI descriptions Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update notation cert Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated per code review Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated per code review Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add config.json
envelopeTypeargument supportTest:
envelopeTypeorenvelopeType= "" orenvelopeType= "jws" AND cli: notation sign -> JWS formatenvelopeTypeorenvelopeType= "" orenvelopeType= "jws" AND cli: notation sign--envelope-type cose-> COSE formatenvelopeType= "cose" AND cli: notation sign -> COSE formatenvelopeType= "cose" AND cli: notation sign--envelope-type jws-> JWS formatenvelopeType= "cosw" AND cli: notation sign ->Error: signature format cosw not supportedenvelopeType= "cosw" AND cli: notation sign--envelope-type jws-> JWS format