Skip to content

notation cert command updates#344

Merged
patrickzheng200 merged 37 commits intonotaryproject:dev-rc.1from
patrickzheng200:dev-rc.1
Sep 23, 2022
Merged

notation cert command updates#344
patrickzheng200 merged 37 commits intonotaryproject:dev-rc.1from
patrickzheng200:dev-rc.1

Conversation

@patrickzheng200
Copy link
Copy Markdown
Contributor

@patrickzheng200 patrickzheng200 commented Sep 22, 2022

  1. Added confirmation to 'notation cert delete' command.
  2. Updated 'notation cert generate-test' to generate self-signed certificate.
  3. Removed tsa support for now, and added signingAuthority.

Signed-off-by: Patrick Zheng patrickzheng@microsoft.com

Patrick Zheng and others added 30 commits September 5, 2022 16:46
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Patrick Zheng added 5 commits September 22, 2022 11:56
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 22, 2022

Codecov Report

Merging #344 (8f52fb0) into dev-rc.1 (ea19589) will decrease coverage by 0.00%.
The diff coverage is 17.18%.

@@             Coverage Diff              @@
##           dev-rc.1     #344      +/-   ##
============================================
- Coverage     27.81%   27.81%   -0.01%     
============================================
  Files            25       25              
  Lines          1880     1884       +4     
============================================
+ Hits            523      524       +1     
- Misses         1340     1343       +3     
  Partials         17       17              
Impacted Files Coverage Δ
cmd/notation/cert_gen.go 0.00% <0.00%> (ø)
cmd/notation/cert.go 20.10% <19.29%> (-0.56%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shizhMSFT shizhMSFT added the dev Issue or PR related to dev branches label Sep 22, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Copy Markdown
Contributor

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, lgtm

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@patrickzheng200 patrickzheng200 merged commit 2a172cc into notaryproject:dev-rc.1 Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev Issue or PR related to dev branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants