Skip to content

feat: An initial implementation of Notation CLI Trust Store#331

Merged
patrickzheng200 merged 17 commits intonotaryproject:dev-rc.1from
patrickzheng200:dev-rc.1
Sep 13, 2022
Merged

feat: An initial implementation of Notation CLI Trust Store#331
patrickzheng200 merged 17 commits intonotaryproject:dev-rc.1from
patrickzheng200:dev-rc.1

Conversation

@patrickzheng200
Copy link
Copy Markdown
Contributor

@patrickzheng200 patrickzheng200 commented Sep 8, 2022

This PR targets the dev-rc.1 branch ONLY.

  1. Implemented 'notation cert add', 'notation cert list', 'notation cert show', and 'notation cert delete' commands.
  2. Temporarily removed logic of 'notation cert generate-test' as this command needs refactor once we finish trust store and trust policy.
  3. Merged new updates by JunJie from the cose branch (i.e. setting up envelope type in config.json).

Signed-off-by: Patrick Zheng patrickzheng@microsoft.com

Patrick Zheng and others added 12 commits September 5, 2022 16:46
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #331 (77d7f19) into dev-rc.1 (6fa490a) will decrease coverage by 1.00%.
The diff coverage is 12.22%.

@@             Coverage Diff              @@
##           dev-rc.1     #331      +/-   ##
============================================
- Coverage     30.07%   29.07%   -1.01%     
============================================
  Files            25       24       -1     
  Lines          1639     1737      +98     
============================================
+ Hits            493      505      +12     
- Misses         1133     1215      +82     
- Partials         13       17       +4     
Impacted Files Coverage Δ
internal/cmd/flags.go 50.00% <0.00%> (-2.75%) ⬇️
internal/cmd/signer.go 0.00% <0.00%> (ø)
cmd/notation/cert.go 17.53% <11.28%> (-17.76%) ⬇️
pkg/configutil/once.go 100.00% <100.00%> (ø)
cmd/notation/cert_gen.go

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@FeynmanZhou
Copy link
Copy Markdown
Member

FeynmanZhou commented Sep 8, 2022

If we removed notation cert generate-test in this PR, we need to consider how to create a test cert with Trust Store implementation.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@patrickzheng200 patrickzheng200 changed the title An initial implementation of Notation CLI Trust Store feat: An initial implementation of Notation CLI Trust Store Sep 9, 2022
Patrick Zheng added 4 commits September 9, 2022 17:09
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@patrickzheng200 patrickzheng200 merged commit 36ad94c into notaryproject:dev-rc.1 Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants