Skip to content

feat: update to go 1.19#327

Merged
shizhMSFT merged 1 commit intonotaryproject:mainfrom
JeyJeyGao:feat/update_go_1.19
Sep 13, 2022
Merged

feat: update to go 1.19#327
shizhMSFT merged 1 commit intonotaryproject:mainfrom
JeyJeyGao:feat/update_go_1.19

Conversation

@JeyJeyGao
Copy link
Copy Markdown
Contributor

@JeyJeyGao JeyJeyGao commented Sep 2, 2022

update:

  1. go.mod
  2. github action

Test:

  1. unit test work well
  2. hello-signing steps work well

Resolves #277

update:
1. go.mod
2. github action

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #327 (7f54d72) into main (8bec8a7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   30.62%   30.62%           
=======================================
  Files          25       25           
  Lines        1610     1610           
=======================================
  Hits          493      493           
  Misses       1104     1104           
  Partials       13       13           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shizhMSFT shizhMSFT requested review from a team September 2, 2022 05:45
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shizhMSFT shizhMSFT merged commit 84db123 into notaryproject:main Sep 13, 2022
chloeyin added a commit that referenced this pull request Sep 13, 2022
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>
chloeyin added a commit that referenced this pull request Sep 13, 2022
* add config.json envelopeType support (#329)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>

* feat: write envelopeType default value to config.json (#330)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>

* feat: update to go 1.19 (#327) (#336)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: zaihaoyin <zaihaoyin@microsoft.com>
patrickzheng200 pushed a commit that referenced this pull request Sep 23, 2022
* notation cert add AND notation cert list for trust store

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* add config.json envelopeType support (#329)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>

* added notation cert show command

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated notation cert add

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated notation cert show

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added notation cert delete

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added test certificates

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* feat: write envelopeType default value to config.json (#330)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>

* updated CLI for trust store

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated notation cert commands with system level FS

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated to use notation-go dev-rc.1 branch

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* feat: update to go 1.19 (#327)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

* updated notation-go

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added cert_test.go for trust store

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated failure messages of notation cert commands

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added notation cert generate-test command

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated trust store implementation

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated trust store implementation

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added confirmation to notation cert delete command

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated generate-test to self-signed cert

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated generate-test to self-signed cert

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated generate-test to self-signed cert

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated notation cert CLI descriptions

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update notation cert

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump up golang to 1.19

5 participants