Skip to content

update: updated trust store implementation#340

Merged
patrickzheng200 merged 24 commits intonotaryproject:dev-rc.1from
patrickzheng200:dev-rc.1
Sep 19, 2022
Merged

update: updated trust store implementation#340
patrickzheng200 merged 24 commits intonotaryproject:dev-rc.1from
patrickzheng200:dev-rc.1

Conversation

@patrickzheng200
Copy link
Copy Markdown
Contributor

@patrickzheng200 patrickzheng200 commented Sep 16, 2022 •
edited
Loading

This PR targets the dev-rc.1 branch.

  1. TrimSpace of storeType, namedStore and cert fileName.
  2. Show all the certificates when a file contains a certificate chain.

Signed-off-by: Patrick Zheng patrickzheng@microsoft.com

Patrick Zheng and others added 22 commits September 5, 2022 16:46
notation cert add AND notation cert list for trust store
372134c 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
update
eec865f 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@JeyJeyGao
add config.json envelopeType support (notaryproject#329)
b799c2b 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
added notation cert show command
45705d9 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
updated notation cert add
dd1f0d0 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
updated notation cert show
fcb9850 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
added notation cert delete
0f8e63f 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
added test certificates
5fb653a 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@JeyJeyGao
feat: write envelopeType default value to config.json (notaryproject#330
e1cb484 
)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
updated CLI for trust store
7ce3a03 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
update
2a76289 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
updated dev-rc.1 with cose branch
0608deb 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
updated notation cert commands with system level FS
1d1c9c3 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
updated to use notation-go dev-rc.1 branch
5bab720 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
updated notation-go
fe6595b 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
added cert_test.go for trust store
77d7f19 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
updated failure messages of notation cert commands
6d425e6 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@patrickzheng200
Merge branch 'notaryproject:dev-rc.1' into dev-rc.1
0e1880a
@patrickzheng200
Merge branch 'notaryproject:dev-rc.1' into dev-rc.1
0704df6
added notation cert generate-test command
900a948 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@patrickzheng200
Merge branch 'notaryproject:dev-rc.1' into dev-rc.1
7c62ca1
updated trust store implementation
9133fab 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 16, 2022 •
edited
Loading

Codecov Report

Merging #340 (2e65ffb) into dev-rc.1 (174e2f9) will decrease coverage by 0.22%.
The diff coverage is 7.50%.

@@             Coverage Diff              @@
##           dev-rc.1     #340      +/-   ##
============================================
- Coverage     28.08%   27.86%   -0.23%     
============================================
  Files            25       25              
  Lines          1862     1877      +15     
============================================
  Hits            523      523              
- Misses         1322     1337      +15     
  Partials         17       17
Impacted Files Coverage Δ
cmd/notation/cert.go 20.83% <7.50%> (-0.91%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

chloeyin
chloeyin reviewed Sep 16, 2022
View reviewed changes
chloeyin
chloeyin reviewed Sep 16, 2022
View reviewed changes
update per code review
2e65ffb 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
binbin-li
binbin-li reviewed Sep 16, 2022
View reviewed changes
update per code review
e245da2 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
binbin-li
binbin-li approved these changes Sep 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@patrickzheng200 patrickzheng200 merged commit ea19589 into notaryproject:dev-rc.1 Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@chloeyin chloeyin chloeyin left review comments

@binbin-li binbin-li binbin-li approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@patrickzheng200 @codecov-commenter @binbin-li @chloeyin @JeyJeyGao