Skip to content

[CP Staging] Revert "Add type expense report"#72987

Merged
luacmartins merged 1 commit into
Expensify:mainfrom
situchan:revert-71800-cmartins-addTypeExpenseReport
Oct 20, 2025
Merged

[CP Staging] Revert "Add type expense report"#72987
luacmartins merged 1 commit into
Expensify:mainfrom
situchan:revert-71800-cmartins-addTypeExpenseReport

Conversation

@situchan

@situchan situchan commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

Reverts #71800

Fixed issues

$ #72986
$ #72979
$ #72976
$ #72971
$ #72996
$ #72959
$ #72957
$ #73029

@codecov

codecov Bot commented Oct 20, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.07407% with 98 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/libs/SearchParser/autocompleteParser.js 71.60% 46 Missing ⚠️
src/libs/SearchParser/searchParser.js 88.88% 18 Missing ⚠️
src/components/Search/index.tsx 0.00% 12 Missing ⚠️
src/pages/Search/AdvancedSearchFilters.tsx 0.00% 5 Missing ⚠️
src/components/Search/SearchList/index.tsx 0.00% 4 Missing ⚠️
src/libs/SearchUIUtils.ts 66.66% 3 Missing ⚠️
...nents/Search/SearchPageHeader/SearchFiltersBar.tsx 0.00% 2 Missing ⚠️
...thSections/Search/TransactionGroupListExpanded.tsx 77.77% 2 Missing ⚠️
...rchAdvancedFiltersPage/SearchFiltersStatusPage.tsx 0.00% 2 Missing ⚠️
src/pages/Search/SearchPage.tsx 0.00% 2 Missing ⚠️
... and 2 more
Files with missing lines Coverage Δ
src/CONST/index.ts 85.84% <ø> (ø)
src/components/Search/SearchAutocompleteList.tsx 0.62% <ø> (+<0.01%) ⬆️
src/libs/actions/IOU.ts 63.03% <100.00%> (-0.29%) ⬇️
src/pages/Search/EmptySearchView.tsx 61.20% <100.00%> (+4.31%) ⬆️
src/types/form/SearchAdvancedFiltersForm.ts 100.00% <ø> (ø)
...stWithSections/Search/TransactionGroupListItem.tsx 92.72% <75.00%> (+1.65%) ⬆️
src/hooks/useAdvancedSearchFilters.ts 0.00% <0.00%> (ø)
...nents/Search/SearchPageHeader/SearchFiltersBar.tsx 0.00% <0.00%> (ø)
...thSections/Search/TransactionGroupListExpanded.tsx 54.43% <77.77%> (ø)
...rchAdvancedFiltersPage/SearchFiltersStatusPage.tsx 0.00% <0.00%> (ø)
... and 7 more

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@melvin-bot

melvin-bot Bot commented Oct 20, 2025

Copy link
Copy Markdown

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@luacmartins
luacmartins requested review from luacmartins and removed request for Gonals October 20, 2025 16:34
@luacmartins luacmartins changed the title Revert "Add type expense report" [CP Staging] Revert "Add type expense report" Oct 20, 2025
@luacmartins

Copy link
Copy Markdown
Contributor

Straight revert. Merging without checklists

@luacmartins
luacmartins merged commit a361f4a into Expensify:main Oct 20, 2025
26 of 32 checks passed
@melvin-bot

melvin-bot Bot commented Oct 20, 2025

Copy link
Copy Markdown

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@luacmartins

Copy link
Copy Markdown
Contributor

See above

OSBotify pushed a commit that referenced this pull request Oct 20, 2025
…ExpenseReport

[CP Staging] Revert "Add type expense report"

(cherry picked from commit a361f4a)

(cherry-picked to staging by blimpich)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 20, 2025
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@IuliiaHerets

Copy link
Copy Markdown

@situchan @luacmartins There are no QA steps. Do we need to QA it?

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.2.34-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@luacmartins

Copy link
Copy Markdown
Contributor

@IuliiaHerets we should follow the QA steps from the linked issues and make sure those are fixed

@IuliiaHerets

Copy link
Copy Markdown

@luacmartins all of them already checked here

@luacmartins

Copy link
Copy Markdown
Contributor

Thank you!

@luacmartins luacmartins mentioned this pull request Oct 20, 2025
62 tasks
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.34-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.2.35-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.2.35-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@situchan
situchan deleted the revert-71800-cmartins-addTypeExpenseReport branch November 4, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants