Add type expense report#71800
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 376e05ad..e826bac7 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -672,6 +672,7 @@ const translations = {
link: 'Link',
pinned: 'Angeheftet',
read: 'Gelesen',
+ expenseReport: 'Spesenabrechnung',
},
supportalNoAccess: {
title: 'Nicht so schnell',
@@ -6187,7 +6188,7 @@ const translations = {
groupBy: {
[CONST.SEARCH.GROUP_BY.FROM]: 'Von',
[CONST.SEARCH.GROUP_BY.CARD]: 'Karte',
- [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'Auszahlungs-ID',
+ [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'Abhebungs-ID',
},
feed: 'Feed',
withdrawalType: {
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 01a8214a..ee231a8b 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -672,6 +672,7 @@ const translations = {
link: 'Lien',
pinned: 'Épinglé',
read: 'Lu',
+ expenseReport: 'Rapport de dépenses',
},
supportalNoAccess: {
title: 'Pas si vite',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 8443ed08..c07fabba 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -672,6 +672,7 @@ const translations = {
link: 'Link',
pinned: 'Fissato',
read: 'Letto',
+ expenseReport: 'Rapporto di Spesa',
},
supportalNoAccess: {
title: 'Non così in fretta',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index e0d16e7a..1212e3d2 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -672,6 +672,7 @@ const translations = {
link: 'リンク',
pinned: '固定済み',
read: '既読',
+ expenseReport: '経費報告書',
},
supportalNoAccess: {
title: 'ちょっと待ってください',
@@ -6138,7 +6139,7 @@ const translations = {
groupBy: {
[CONST.SEARCH.GROUP_BY.FROM]: 'から',
[CONST.SEARCH.GROUP_BY.CARD]: 'カード',
- [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '出金ID',
+ [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '引き出しID',
},
feed: 'フィード',
withdrawalType: {
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 73a30544..ec1c2c24 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -671,6 +671,7 @@ const translations = {
link: 'Link',
pinned: 'Vastgezet',
read: 'Gelezen',
+ expenseReport: 'Onkostennota',
},
supportalNoAccess: {
title: 'Niet zo snel',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index e6fcfd2a..e01f669b 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -672,6 +672,7 @@ const translations = {
link: 'Link',
pinned: 'Przypięte',
read: 'Przeczytane',
+ expenseReport: 'Raport wydatków',
},
supportalNoAccess: {
title: 'Nie tak szybko',
@@ -6172,7 +6173,7 @@ const translations = {
groupBy: {
[CONST.SEARCH.GROUP_BY.FROM]: 'Od',
[CONST.SEARCH.GROUP_BY.CARD]: 'Karta',
- [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'Identyfikator wypłaty',
+ [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID wypłaty',
},
feed: 'Kanal',
withdrawalType: {
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 4ef31a7f..b05b4f62 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -672,6 +672,7 @@ const translations = {
link: 'Link',
pinned: 'Fixado',
read: 'Lido',
+ expenseReport: 'Relatório de Despesas',
},
supportalNoAccess: {
title: 'Não tão rápido',
@@ -6186,7 +6187,7 @@ const translations = {
groupBy: {
[CONST.SEARCH.GROUP_BY.FROM]: 'De',
[CONST.SEARCH.GROUP_BY.CARD]: 'Cartão',
- [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID de retirada',
+ [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID de Retirada',
},
feed: 'Feed',
withdrawalType: {
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index b1612bd3..f26f7061 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -671,6 +671,7 @@ const translations = {
link: '链接',
pinned: '已固定',
read: '已读',
+ expenseReport: '费用报告',
},
supportalNoAccess: {
title: '慢一点',
@@ -6057,7 +6058,7 @@ const translations = {
groupBy: {
[CONST.SEARCH.GROUP_BY.FROM]: '从',
[CONST.SEARCH.GROUP_BY.CARD]: '卡片',
- [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '提现ID',
+ [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '提现 ID',
},
feed: '通道',
withdrawalType: {
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Contributor
Author
|
@JS00001 ready for review! |
Contributor
Author
|
conflicts again 😢 |
Contributor
|
Prettiers failing |
Contributor
Author
|
of course lol |
situchan
reviewed
Oct 17, 2025
Contributor
|
LGTM |
. Thank you for your hard work!
JS00001
approved these changes
Oct 17, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
44 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.34-0 🚀
|
This was referenced Oct 20, 2025
8 tasks
This was referenced Oct 20, 2025
Closed
8 tasks
This was referenced Oct 20, 2025
8 tasks
Contributor
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.34-2 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Deprecates
group-by:reportin favor oftype:expense-reportFixed Issues
$ https://github.com/Expensify/Expensify/issues/552406
Tests
Additionally, while on Reports > Reports verify that you can use any of the filters in the RHP and the query works
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop