Add type expense report v2 by luacmartins · Pull Request #73039 · Expensify/App

luacmartins · 2025-10-20T21:26:58Z

Explanation of Change

Deprecates group-by:report in favor of type:expense-report

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/552406

Additionally, it addresses the following blockers identified by QA:

Reports - Non-reimbursable report appears on Reports > Pay section #72957
Reports - When type is Expense Report, invoice appears briefly, empty state buttons disappear #72959
Reports - "Expenses" is missing on Reports > Reports, error when searched with expense-type #72971
Reports - Navigation arrows do not appear on Reports > Reports #72976
Reports - In reports page, tapping basic export shows error #72979
Reports - "Total Spend" field changes to "0.00" after selecting a report. #72986
Reports - Pay button persists in dropdown menu after paying from the action button #72996
Reports - Disabled cursor is not shown when hovering over Select all checkbox #73029

Tests

Navigate to the following pages and verify that the query works

Reports > Reports
Reports > Submit
Reports > Approve
Reports > Pay
Reports > Export

Additionally, while on Reports > Reports verify that you can use any of the filters in the RHP and the query works

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…penseReport

luacmartins · 2025-10-21T21:31:31Z

Reports - Non-reimbursable report appears on Reports > Pay section #72957

Fixed by BE PR https://github.com/Expensify/Auth/pull/17746

Screen.Recording.2025-10-21.at.3.31.06.PM.mov

luacmartins · 2025-10-21T21:32:59Z

Reports - When type is Expense Report, invoice appears briefly, empty state buttons disappear #72959
Fixed by commit df74530

Screen.Recording.2025-10-21.at.3.32.09.PM.mov

luacmartins · 2025-10-21T21:33:34Z

Reports - "Expenses" is missing on Reports > Reports, error when searched with expense-type #72971

This is expected. The type:expense-report filters don't include any expense filters, only report level filters.

luacmartins · 2025-10-21T21:34:22Z

Reports - Navigation arrows do not appear on Reports > Reports #72976

Fixed by commit 729fee0

Screen.Recording.2025-10-21.at.3.34.10.PM.mov

luacmartins · 2025-10-21T21:35:50Z

Reports - In reports page, tapping basic export shows error #72979

Fixed by BE PR

Screen.Recording.2025-10-21.at.3.35.36.PM.mov

luacmartins · 2025-10-21T21:38:26Z

Reports - "Total Spend" field changes to "0.00" after selecting a report. #72986
Fixed by BE PR https://github.com/Expensify/Auth/pull/17782

Screen.Recording.2025-10-21.at.3.38.07.PM.mov

luacmartins · 2025-10-21T21:40:34Z

Reports - Pay button persists in dropdown menu after paying from the action button #72996

Fixed by commit c1516a0

Screen.Recording.2025-10-21.at.3.40.11.PM.mov

luacmartins · 2025-10-21T21:41:45Z

Reports - Disabled cursor is not shown when hovering over Select all checkbox #73029
Fixed by commit 6fed7fa

Screen.Recording.2025-10-21.at.3.27.26.PM.mov

melvin-bot · 2025-10-21T22:33:56Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-10-21T22:34:07Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2025-10-23T18:25:00Z

@situchan for this one #72959, I'm gonna push a FE fix, but it also requires a BE fix. I don't think we need to block on this since we show the empty modal and the BE PR should be deployed faster than our FE PR.

luacmartins · 2025-10-23T18:57:12Z

@situchan this should be ready for review again. #72959 will not work properly until the BE fix is deployed, but let's not block on that.

situchan · 2025-10-23T19:07:10Z

If you see video around 16s-18s, there's flicker, but let's not block on this.

Screen.Recording.2025-10-24.at.12.58.53.AM.mov

luacmartins · 2025-10-23T19:21:44Z

Yea, that's when the API responds. We can address that as a separate issue.

situchan · 2025-10-23T19:36:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

situchan · 2025-10-23T19:38:57Z

All regression tests pass except empty view case mentioned above.

mchrome.mov

melvin-bot · 2025-10-23T19:39:11Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-10-23T19:39:15Z

🎯 @situchan, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #73350.

situchan · 2025-10-24T11:49:37Z

Conflicts!

OSBotify · 2025-10-24T16:02:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-24T18:18:23Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.38-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

situchan · 2025-10-24T18:57:50Z

Let's be on the lookout for any regressions caught in staging during weekend

OSBotify · 2025-10-27T20:07:47Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.38-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

eh2077 · 2025-12-18T01:11:23Z

+                if (hasResults) {
+                    return {
+                        ...defaultViewItemHeader,
+                        title: translate('search.searchResults.emptyResults.title'),
+                        subtitle: translate('search.searchResults.emptyResults.subtitle'),
+                    };
+                }


This caused

[Due for payment 2025-12-17] [$250] Reports-After deleting IOU, nothing to show is shown briefly before updating to default page #75366

because hasResults value returned from the backend is not updated immediately after deleting all expenses.

Revert "[CP Staging] Revert "Add type expense report""

b138080

luacmartins self-assigned this Oct 20, 2025

This comment was marked as outdated.

Sign in to view

This comment was marked as spam.

Sign in to view

luacmartins added 6 commits October 20, 2025 17:04

Merge branch 'main' into revert-72987-revert-71800-cmartins-addTypeEx…

f943184

…penseReport

resolve conflicts

afd394b

fix 72959

df74530

fix 72976

729fee0

resolve conflicts

c29832b

fix 72996

c1516a0

fix 73029

6fed7fa

fix lint

56afe9c

luacmartins marked this pull request as ready for review October 21, 2025 22:33

luacmartins requested a review from a team as a code owner October 21, 2025 22:33

melvin-bot Bot requested a review from DylanDylann October 21, 2025 22:33

melvin-bot Bot removed the request for review from a team October 21, 2025 22:33

luacmartins requested review from a team and situchan October 21, 2025 22:34

melvin-bot Bot requested review from mananjadhav and removed request for a team October 21, 2025 22:34

luacmartins added 2 commits October 23, 2025 12:26

fix empty report view

5565970

rm tests

b9d3c87

situchan approved these changes Oct 23, 2025

View reviewed changes

melvin-bot Bot requested a review from mollfpr October 23, 2025 19:39

melvin-bot Bot mentioned this pull request Oct 23, 2025

[$250] Payment issue for E/App PR#73039 #73350

Closed

luacmartins requested a review from JS00001 October 23, 2025 20:04

JS00001 previously approved these changes Oct 24, 2025

View reviewed changes

resolve conflicts

2875f4f

luacmartins dismissed JS00001’s stale review via 2875f4f October 24, 2025 15:02

resolve conflicts

332b6b2

JS00001 approved these changes Oct 24, 2025

View reviewed changes

luacmartins merged commit 1d38504 into main Oct 24, 2025
33 of 34 checks passed

luacmartins deleted the revert-72987-revert-71800-cmartins-addTypeExpenseReport branch October 24, 2025 15:49

OSBotify mentioned this pull request Oct 24, 2025

Deploy Checklist: New Expensify 2025-10-24 #73445

Closed

71 tasks

mukhrr mentioned this pull request Oct 30, 2025

Report - group-by:report is not listed on the autocomplete suggestions list #73801

Closed

8 tasks

eh2077 reviewed Dec 18, 2025

View reviewed changes

MelvinBot mentioned this pull request Jun 23, 2026

[$250] Search - Error occurs after adding "group-by: reports" to the search query #89168

Open

7 tasks

Uh oh!

Conversation

luacmartins commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

This comment was marked as outdated.

This comment was marked as spam.

luacmartins commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Oct 21, 2025

Uh oh!

luacmartins commented Oct 21, 2025

Uh oh!

luacmartins commented Oct 21, 2025

Uh oh!

luacmartins commented Oct 21, 2025

Uh oh!

luacmartins commented Oct 21, 2025

Uh oh!

luacmartins commented Oct 21, 2025

Uh oh!

luacmartins commented Oct 21, 2025

Uh oh!

melvin-bot Bot commented Oct 21, 2025

Uh oh!

melvin-bot Bot commented Oct 21, 2025

Uh oh!

luacmartins commented Oct 23, 2025

Uh oh!

luacmartins commented Oct 23, 2025

Uh oh!

situchan commented Oct 23, 2025

Uh oh!

luacmartins commented Oct 23, 2025

Uh oh!

situchan commented Oct 23, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Oct 23, 2025

Uh oh!

melvin-bot Bot commented Oct 23, 2025

Uh oh!

melvin-bot Bot commented Oct 23, 2025

Uh oh!

situchan commented Oct 24, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 24, 2025

Uh oh!

OSBotify commented Oct 24, 2025

Uh oh!

situchan commented Oct 24, 2025

Uh oh!

OSBotify commented Oct 27, 2025

Uh oh!

eh2077 Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

luacmartins commented Oct 20, 2025 •

edited

Loading

luacmartins commented Oct 21, 2025 •

edited

Loading