Skip to content

Revert "Add type expense report"#72992

Closed
grgia wants to merge 1 commit into
mainfrom
revert-71800-cmartins-addTypeExpenseReport
Closed

Revert "Add type expense report"#72992
grgia wants to merge 1 commit into
mainfrom
revert-71800-cmartins-addTypeExpenseReport

Conversation

@grgia

@grgia grgia commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

Reverts #71800

@grgia grgia self-assigned this Oct 20, 2025
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 39f3dec0..51e15f16 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -6273,10 +6273,10 @@ ${amount} per ${merchant} - ${date}`,
             reimbursable: 'Rimborsabile',
             purchaseCurrency: 'Valuta di acquisto',
             groupBy: {
-                [CONST.SEARCH.GROUP_BY.REPORTS]: 'Rapporto',
+                [CONST.SEARCH.GROUP_BY.REPORTS]: 'Resoconto',
                 [CONST.SEARCH.GROUP_BY.FROM]: 'Da',
                 [CONST.SEARCH.GROUP_BY.CARD]: 'Carta',
-                [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID di prelievo',
+                [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID del prelievo',
             },
             feed: 'Feed',
             withdrawalType: {
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index d9c2f2e5..5af0b943 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -6208,7 +6208,7 @@ ${date} - ${merchant}に${amount}`,
             reimbursable: '払い戻し可能',
             purchaseCurrency: '購入通貨',
             groupBy: {
-                [CONST.SEARCH.GROUP_BY.REPORTS]: '報告',
+                [CONST.SEARCH.GROUP_BY.REPORTS]: 'レポート',
                 [CONST.SEARCH.GROUP_BY.FROM]: 'から',
                 [CONST.SEARCH.GROUP_BY.CARD]: 'カード',
                 [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '出金ID',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index b63cf25c..8112c7b5 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -6257,7 +6257,7 @@ ${amount} voor ${merchant} - ${date}`,
             reimbursable: 'Vergoedbaar',
             purchaseCurrency: 'Aankoopvaluta',
             groupBy: {
-                [CONST.SEARCH.GROUP_BY.REPORTS]: 'Verslag',
+                [CONST.SEARCH.GROUP_BY.REPORTS]: 'Rapport',
                 [CONST.SEARCH.GROUP_BY.FROM]: 'Van',
                 [CONST.SEARCH.GROUP_BY.CARD]: 'Kaart',
                 [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'Opname-ID',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 113656f4..f37c805e 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -6246,7 +6246,7 @@ ${amount} dla ${merchant} - ${date}`,
                 [CONST.SEARCH.GROUP_BY.REPORTS]: 'Raport',
                 [CONST.SEARCH.GROUP_BY.FROM]: 'Od',
                 [CONST.SEARCH.GROUP_BY.CARD]: 'Karta',
-                [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'Identyfikator wypłaty',
+                [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'Identyfikator wypłaty', //_/\__/_/  \_,_/\__/\__/\_,_/
             },
             feed: 'Kanal',
             withdrawalType: {
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index d9ee8f96..b0efdd6f 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -6255,7 +6255,7 @@ ${amount} para ${merchant} - ${date}`,
                 [CONST.SEARCH.GROUP_BY.REPORTS]: 'Relatório',
                 [CONST.SEARCH.GROUP_BY.FROM]: 'De',
                 [CONST.SEARCH.GROUP_BY.CARD]: 'Cartão',
-                [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID de retirada',
+                [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID do saque',
             },
             feed: 'Feed',
             withdrawalType: {
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index e4029329..5873fe4b 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -6131,9 +6131,9 @@ ${merchant}的${amount} - ${date}`,
             purchaseCurrency: '购买货币',
             groupBy: {
                 [CONST.SEARCH.GROUP_BY.REPORTS]: '报告',
-                [CONST.SEARCH.GROUP_BY.FROM]: '从',
-                [CONST.SEARCH.GROUP_BY.CARD]: '卡片',
-                [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '提现ID',
+                [CONST.SEARCH.GROUP_BY.FROM]: '来自',
+                [CONST.SEARCH.GROUP_BY.CARD]: '卡',
+                [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '提现编号',
             },
             feed: '通道',
             withdrawalType: {

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72992.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://72992.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@codecov

codecov Bot commented Oct 20, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.07407% with 98 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/libs/SearchParser/autocompleteParser.js 71.60% 46 Missing ⚠️
src/libs/SearchParser/searchParser.js 88.88% 18 Missing ⚠️
src/components/Search/index.tsx 0.00% 12 Missing ⚠️
src/pages/Search/AdvancedSearchFilters.tsx 0.00% 5 Missing ⚠️
src/components/Search/SearchList/index.tsx 0.00% 4 Missing ⚠️
src/libs/SearchUIUtils.ts 66.66% 3 Missing ⚠️
...nents/Search/SearchPageHeader/SearchFiltersBar.tsx 0.00% 2 Missing ⚠️
...thSections/Search/TransactionGroupListExpanded.tsx 77.77% 2 Missing ⚠️
...rchAdvancedFiltersPage/SearchFiltersStatusPage.tsx 0.00% 2 Missing ⚠️
src/pages/Search/SearchPage.tsx 0.00% 2 Missing ⚠️
... and 2 more
Files with missing lines Coverage Δ
src/CONST/index.ts 85.84% <ø> (ø)
src/components/Search/SearchAutocompleteList.tsx 0.62% <ø> (+<0.01%) ⬆️
src/libs/actions/IOU.ts 63.26% <100.00%> (-0.06%) ⬇️
src/pages/Search/EmptySearchView.tsx 61.20% <100.00%> (+4.31%) ⬆️
src/types/form/SearchAdvancedFiltersForm.ts 100.00% <ø> (ø)
...stWithSections/Search/TransactionGroupListItem.tsx 92.72% <75.00%> (+1.65%) ⬆️
src/hooks/useAdvancedSearchFilters.ts 0.00% <0.00%> (ø)
...nents/Search/SearchPageHeader/SearchFiltersBar.tsx 0.00% <0.00%> (ø)
...thSections/Search/TransactionGroupListExpanded.tsx 54.43% <77.77%> (ø)
...rchAdvancedFiltersPage/SearchFiltersStatusPage.tsx 0.00% <0.00%> (ø)
... and 7 more

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@grgia grgia closed this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants