Conversation
…expression Removes interpolation_type from all fenics adapter config files.
Output frequency of heat.py must match frequency of OpenFOAM Fluid case. Compare writeInterval in controlDict (https://github.com/precice/openfoam-adapter/blob/develop/tutorials/CHT/flow-over-plate/buoyantPimpleFoam-laplacianFoam/Fluid/system/controlDict).
Ensures compatibility with changes introduced in precice/fenics-adapter@fef80b7
Replace deal.II cylinderFlap tutorial with fsi3
Change FEniCS tutorials to handle new initialization signature of FEniCS-Adapter
* Add a file-size checker in a GitHubCI * Add coloring for failed image sizes * Remove verbosity of passing images * Increase limit for gifs to 2000kb * Increase gif limit to 2200 kb
Work mostly by @fsimonis, minor changes by me. Co-authored-by Frédéric Simonis <simonisfrederic@gmail.com>
MakisH
approved these changes
Apr 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mainly concerns the restructuring: https://github.com/orgs/precice/projects/5
TODO:
precice-config.xmls for consistencyTest all cases manually and compare results where possible
Checklist for the manual tests:
run.shclean.sh(maybe wait for @MakisH )READMEfile on the websiteWhile merging this PR: