Change FEniCS tutorials to handle new initialization signature of FEniCS-Adapter#119
Merged
IshaanDesai merged 4 commits intodevelopfrom Nov 28, 2020
Merged
Change FEniCS tutorials to handle new initialization signature of FEniCS-Adapter#119IshaanDesai merged 4 commits intodevelopfrom
IshaanDesai merged 4 commits intodevelopfrom
Conversation
2 tasks
uekerman
reviewed
Nov 25, 2020
BenjaminRodenberg
approved these changes
Nov 27, 2020
Contributor
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Looks good to me 👍 I ran the HT and CHT cases.
Contributor
|
Correction: Will be fixed in #127 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initialization signature of the FEniCS-Adapter is changed in precice/fenics-adapter#101. Correspondingly all FEniCS tutorials need to use the new initialization.
Not to be merged before precice/fenics-adapter#101