Rename fenicsadapter to fenicsprecice#113
Merged
BenjaminRodenberg merged 5 commits intodevelopfrom Nov 6, 2020
Merged
Conversation
Ensures compatibility with changes introduced in precice/fenics-adapter@fef80b7
Contributor
Author
|
@IshaanDesai I hope that I'm not missing something. Can you double-check? |
MakisH
requested changes
Oct 30, 2020
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Attention: please change the target branch to develop first.
Contributor
Author
Done. Thanks for the hint! |
MakisH
approved these changes
Nov 6, 2020
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
With a quick look, it looks ok. Target branch ok, the code you changed should not cause any effects in other parts.
BenjaminRodenberg
added a commit
that referenced
this pull request
Dec 7, 2020
Ensures compatibility with changes introduced in precice/fenics-adapter@fef80b7
BenjaminRodenberg
added a commit
that referenced
this pull request
Dec 7, 2020
Ensures compatibility with changes introduced in precice/fenics-adapter@fef80b7
BenjaminRodenberg
added a commit
that referenced
this pull request
Dec 7, 2020
Ensures compatibility with changes introduced in precice/fenics-adapter@fef80b7
BenjaminRodenberg
added a commit
that referenced
this pull request
Dec 23, 2020
Ensures compatibility with changes introduced in precice/fenics-adapter@fef80b7
BenjaminRodenberg
added a commit
that referenced
this pull request
Jan 8, 2021
Ensures compatibility with changes introduced in precice/fenics-adapter@fef80b7
BenjaminRodenberg
added a commit
that referenced
this pull request
Jan 8, 2021
Ensures compatibility with changes introduced in precice/fenics-adapter@fef80b7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures compatibility with changes introduced in precice/fenics-adapter@fef80b7