Restructure quickstart#145
Conversation
|
Ready for review, but still in draft in order to avoid an accidental merge. |
ab358ca to
a88fce0
Compare
|
Please remember to not merge this before everything else is merged. Otherwise we change the content here: https://www.precice.org/quickstart.html |
MakisH
left a comment
There was a problem hiding this comment.
A few minor comments, mostly very picky changes in the formulations and a rather important bug prevention in the scripts.
I ran the case and I observed that:
- ✔️ The case is running
- ❌ The
removeObsoleteFolders.shneeds to remove thecd Fluidand thecd ... - ✔️ The
plotDisplacement.shworks - ✔️ ParaView works.
- ❔ I still see a kind-of "explosion" in the second half of the simulation (higher-frequency oscillation). Maybe we could add a note that this is expected and why.
- ❌
clean.shneeds a few fixes (see review)
Looks very nice already! 🚀
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
MakisH
left a comment
There was a problem hiding this comment.
A few more minor changes in the README.md (sorry, I only saw them now)
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
…tutorials into restructure-quickstart
|
I added now a result figure. Feel free to comment on it. Other than that, the PR should be ready. |
Just a reminder |
|
@MakisH merging |
|
I looked at the commit with the cleaning/running and the latest state and it looks good 👍. |
Open TODOs: