amd-ci: update build_root to rhel-9, remove unused config - #82276
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
WalkthroughAMD CI release YAMLs now use the RHEL 9, Go 1.24, OpenShift 4.22 build image. Prerelease version bounds and explicit AMD GPU E2E cluster cleanup/profile settings are removed across the configured release streams. ChangesAMD CI release configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse pull-ci-rh-ecosystem-edge-amd-ci-main-4.20-stable-e2e-amd-ci-1-5-x |
|
@TomerNewman: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
02cc60d to
6972e07
Compare
|
/pj-rehearse pull-ci-rh-ecosystem-edge-amd-ci-main-4.20-stable-e2e-amd-ci-1-5-x |
|
@TomerNewman: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.17-stable.yaml (1)
25-30: 🚀 Performance & Scalability | 🟠 Major | ⚡ Quick winRestore
cluster_profileon these AMD E2E jobs.ci-operator/platform-balance/step-jobs-by-platform.pyonly classifies tests that havesteps.cluster_profile, so these entries are dropped from platform balancing without it:
ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.17-stable.yamlci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.18-stable.yaml🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.17-stable.yaml` around lines 25 - 30, Restore the missing cluster_profile field for all AMD E2E job entries so platform balancing can classify them: update ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.17-stable.yaml at lines 25-30 and 32-41, and ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.18-stable.yaml at lines 25-41. Add the field under each job’s steps configuration while preserving the existing AMD driver, GPU Operator, cluster, PCI device, and workflow settings.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In
`@ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.17-stable.yaml`:
- Around line 25-30: Restore the missing cluster_profile field for all AMD E2E
job entries so platform balancing can classify them: update
ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.17-stable.yaml
at lines 25-30 and 32-41, and
ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.18-stable.yaml
at lines 25-41. Add the field under each job’s steps configuration while
preserving the existing AMD driver, GPU Operator, cluster, PCI device, and
workflow settings.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: a6774001-7698-4103-926e-80eaaa8c2bde
⛔ Files ignored due to path filters (1)
ci-operator/jobs/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (10)
ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main.yamlci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.16-stable.yamlci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.17-stable.yamlci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.18-stable.yamlci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.19-stable.yamlci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.20-stable.yamlci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.21-stable.yamlci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.22-stable.yamlci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.23-stable.yamlci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__5.0-stable.yaml
🚧 Files skipped from review as they are similar to previous changes (8)
- ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main.yaml
- ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.21-stable.yaml
- ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.19-stable.yaml
- ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__5.0-stable.yaml
- ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.22-stable.yaml
- ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.23-stable.yaml
- ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.16-stable.yaml
- ci-operator/config/rh-ecosystem-edge/amd-ci/rh-ecosystem-edge-amd-ci-main__4.20-stable.yaml
|
/pj-rehearse pull-ci-rh-ecosystem-edge-amd-ci-main-4.20-stable-e2e-amd-ci-1-5-x |
|
@TomerNewman: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
Bot
added
the
needs-rebase
6972e07 to
281853d
Compare
openshift-ci
Bot
removed
the
needs-rebase
TomerNewman
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
[REHEARSALNOTIFIER]
A total of 29 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@TomerNewman: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@TomerNewman: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggordaniRed, TomerNewman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
/cc @NataliShemtov
Summary by CodeRabbit
Updates
rh-ecosystem-edgeAMD CI configuration inci-operator/config/rh-ecosystem-edge/amd-ciacross 10 YAML variants to bump thebuild_rootimage stream tag from the RHEL 8 / OpenShift 4.12 / Go 1.18 release (rhel-8-release-golang-1.18-openshift-4.12) to the RHEL 9 / OpenShift 4.22 / Go 1.24 release (rhel-9-release-golang-1.24-openshift-4.22). It also removes the now-unusedreleases.latest.prereleaseversion bounds blocks from 9 of the variant files, and simplifies the AMD GPU e2e test step configuration by removing the redundantSKIP_CLUSTER_DELETE: "false"environment variable (and the correspondingsteps.cluster_profile: aws-edge-infrawhere present).TomerNewman requested rehearsal of the
pull-ci-rh-ecosystem-edge...e2e-amd-ci-1-5-xjob three times.