Skip to content

API review evals, bump go version - #82359

Open
theobarberbany wants to merge 1 commit into
openshift:mainfrom
theobarberbany:tb/fix-eval-go-version
Open

API review evals, bump go version#82359
theobarberbany wants to merge 1 commit into
openshift:mainfrom
theobarberbany:tb/fix-eval-go-version

Conversation

@theobarberbany

@theobarberbany theobarberbany commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Updates the OpenShift API master evaluation CI configuration to use the Go 1.26 build image for OpenShift 5.0, replacing the Go 1.24/OpenShift 4.22 image.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5458b7a0-4526-4fd5-95e2-a85406555a8a

📥 Commits

Reviewing files that changed from the base of the PR and between e6fa162 and 769a2ec.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/api/openshift-api-master__evals.yaml

Walkthrough

The OpenShift API CI configuration updates its build root image stream tag from the Go 1.24/OpenShift 4.22 image to the Go 1.26/OpenShift 5.0 image.

Changes

OpenShift API build root

Layer / File(s) Summary
Update build root image tag
ci-operator/config/openshift/api/openshift-api-master__evals.yaml
Changes the configured build root image stream tag to rhel-9-release-golang-1.26-openshift-5.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: lgtm, approved, ok-to-test

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: an API review evals config update that bumps the Go version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a ci-operator YAML changed; no Ginkgo test titles were added or edited, and the names present are static (eval, eval-periodic).
Test Structure And Quality ✅ Passed PR only updates a ci-operator YAML build-root Go tag; it adds no Ginkgo tests to review.
Microshift Test Compatibility ✅ Passed PR only updates a ci-operator build_root image tag in YAML; no new Ginkgo tests or test logic were added, so MicroShift compatibility isn’t affected.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a ci-operator YAML build_root Go tag changed; no Ginkgo tests or SNO-relevant code were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only a ci-operator build_root golang image tag changed; no deployment manifests, controllers, affinity, node selectors, or replica settings were modified.
Ote Binary Stdout Contract ✅ Passed Only a CI YAML build-root image tag changed; no process-level code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only a ci-operator build_root image tag changed; no Ginkgo e2e tests or network-sensitive code were added, so this check is not applicable.
No-Weak-Crypto ✅ Passed Only a build_root image tag changed in a YAML config; no weak-crypto algorithms, custom crypto, or secret comparisons were introduced.
Container-Privileges ✅ Passed The only changed file updates a build_root image tag; no privileged, hostPID/Network/IPC, allowPrivilegeEscalation, or SYS_ADMIN settings appear in the diff or file.
No-Sensitive-Data-In-Logs ✅ Passed The diff only updates a build_root image tag in CI config; no logging statements or secrets/PII appear in the touched file.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from JoelSpeed and everettraven July 23, 2026 15:42
@JoelSpeed

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@theobarberbany: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-api-master-evals-eval openshift/api presubmit Ci-operator config changed
periodic-ci-openshift-api-master-evals-eval-periodic N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2026
@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2026
@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@theobarberbany: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@theobarberbany

Copy link
Copy Markdown
Contributor Author

/pj-rehearse skip

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@theobarberbany: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants