Skip to content

Remove unused OCP release import from operator e2e configs - #82262

Closed
dustman9000 wants to merge 1 commit into
openshift:mainfrom
dustman9000:rosaeng-60066/remove-release-import
Closed

Remove unused OCP release import from operator e2e configs#82262
dustman9000 wants to merge 1 commit into
openshift:mainfrom
dustman9000:rosaeng-60066/remove-release-import

Conversation

@dustman9000

@dustman9000 dustman9000 commented Jul 22, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary

Remove the releases.latest block from all 5 SRE operator e2e ci-operator configs (RMO, CAMO, AVO, MUO, OAO).

Context

The operator e2e jobs import the full OCP release payload (~197 images) via releases.latest.candidate but never use any release images. The rosa-cluster-lease-e2e-workflow only uses rosa-aws-cli as a base image.

The release import creates a release-images-latest pod that takes ~2 minutes to pull and tag 197 images. During build cluster pressure (DiskPressure, scheduling delays), this pod was stuck in Pending for over an hour, causing the entire promotion job to fail before any test steps ran.

Removing it eliminates an unnecessary pod, reduces build cluster pressure, and speeds up job startup by ~2 minutes.

Jira: https://redhat.atlassian.net/browse/ROSAENG-60066

Test plan

  • /pj-rehearse all affected operator e2e jobs
  • Verify checkout/install/e2e steps still work without release images

Summary by CodeRabbit

  • Removed unused OpenShift release imports from five SRE operator CI configurations: RMO, CAMO, AVO, MUO, and OAO.
  • Prevents importing approximately 197 unnecessary release images and eliminates the release-images-latest pod.
  • Reduces build-cluster pressure and expected job startup time by about two minutes while preserving existing tests and images.

@dustman9000
Remove unused OCP release import from operator e2e configs
69d2fc8 
The operator e2e jobs import the full OCP release payload (197
images) but never use any release images. The rosa-cluster-lease
workflow only needs rosa-aws-cli. Removing the release import
eliminates the release-images-latest pod, reducing build cluster
pressure and avoiding scheduling delays.
@openshift-ci
openshift-ci Bot requested review from charlesgong and clcollins July 22, 2026 01:21
@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2026
@coderabbitai

coderabbitai Bot commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b95c0798-91db-465f-87c5-8e3f99993228

📥 Commits

Reviewing files that changed from the base of the PR and between 307236e and 69d2fc8.

⛔ Files ignored due to path filters (15)
  • ci-operator/jobs/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/route-monitor-operator/openshift-route-monitor-operator-master-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/route-monitor-operator/openshift-route-monitor-operator-master-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/route-monitor-operator/openshift-route-monitor-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (5)
  • ci-operator/config/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main.yaml
  • ci-operator/config/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master.yaml
  • ci-operator/config/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master.yaml
  • ci-operator/config/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master.yaml
  • ci-operator/config/openshift/route-monitor-operator/openshift-route-monitor-operator-master.yaml
💤 Files with no reviewable changes (5)
  • ci-operator/config/openshift/route-monitor-operator/openshift-route-monitor-operator-master.yaml
  • ci-operator/config/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main.yaml
  • ci-operator/config/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master.yaml
  • ci-operator/config/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master.yaml
  • ci-operator/config/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master.yaml

Walkthrough

Five OpenShift CI operator configurations remove their releases.latest.candidate selectors for the OCP 4.22 CI stream. Existing image, resource, and test configuration remains unchanged.

Changes

Release Pin Removal

Layer / File(s) Summary
Remove candidate release selectors
ci-operator/config/openshift/{aws-vpce-operator,configure-alertmanager-operator,managed-upgrade-operator,ocm-agent-operator,route-monitor-operator}/*.yaml		 The pinned ocp/ci/4.22 candidate release blocks are removed, leaving resources directly after the image definitions.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing an unused OCP release import from operator e2e CI configs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only ci-operator config/job YAML changed; no Ginkgo It/Describe/Context/When titles were added or edited.
Test Structure And Quality ✅ Passed No Ginkgo test code changed; the PR only edits ci-operator YAML configs/jobs, so the test-structure quality check is not applicable.
Microshift Test Compatibility ✅ Passed PR only edits ci-operator YAML configs to remove releases.latest; no Ginkgo e2e tests or MicroShift-sensitive APIs/features were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo tests were added; the PR only removes release selectors from ci-operator YAML configs, so SNO compatibility is not implicated.
Topology-Aware Scheduling Compatibility ✅ Passed The PR only removes releases.latest from ci-operator/job YAMLs; no manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed PR only edits five YAML CI configs removing releases.latest; no process-level Go/test binary stdout code changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The PR only removes releases.latest from ci-operator YAML/job configs; no new or modified Ginkgo e2e test code was added.
No-Weak-Crypto ✅ Passed Diff only removes release/job-release and ci-pull-credentials references; no MD5/SHA1/DES/RC4/3DES/ECB, custom crypto, or secret comparisons found.
Container-Privileges ✅ Passed Diff only removes releases.latest/job-release; no changed YAML adds privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed PR only removes releases.latest YAML; no logging code or added sensitive fields appear in the diff.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

openshift-merge-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@dustman9000: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-route-monitor-operator-master-rosa-sts-e2e openshift/route-monitor-operator presubmit Presubmit changed
pull-ci-openshift-route-monitor-operator-master-coverage openshift/route-monitor-operator presubmit Ci-operator config changed
pull-ci-openshift-route-monitor-operator-master-e2e-binary-build-success openshift/route-monitor-operator presubmit Ci-operator config changed
pull-ci-openshift-route-monitor-operator-master-generate openshift/route-monitor-operator presubmit Ci-operator config changed
pull-ci-openshift-route-monitor-operator-master-images openshift/route-monitor-operator presubmit Ci-operator config changed
pull-ci-openshift-route-monitor-operator-master-lint openshift/route-monitor-operator presubmit Ci-operator config changed
pull-ci-openshift-route-monitor-operator-master-test openshift/route-monitor-operator presubmit Ci-operator config changed
pull-ci-openshift-aws-vpce-operator-main-rosa-sts-e2e openshift/aws-vpce-operator presubmit Presubmit changed
pull-ci-openshift-aws-vpce-operator-main-coverage openshift/aws-vpce-operator presubmit Ci-operator config changed
pull-ci-openshift-aws-vpce-operator-main-e2e-binary-build-success openshift/aws-vpce-operator presubmit Ci-operator config changed
pull-ci-openshift-aws-vpce-operator-main-images openshift/aws-vpce-operator presubmit Ci-operator config changed
pull-ci-openshift-aws-vpce-operator-main-lint openshift/aws-vpce-operator presubmit Ci-operator config changed
pull-ci-openshift-aws-vpce-operator-main-test openshift/aws-vpce-operator presubmit Ci-operator config changed
pull-ci-openshift-aws-vpce-operator-main-validate openshift/aws-vpce-operator presubmit Ci-operator config changed
pull-ci-openshift-ocm-agent-operator-master-rosa-sts-e2e openshift/ocm-agent-operator presubmit Presubmit changed
pull-ci-openshift-ocm-agent-operator-master-coverage openshift/ocm-agent-operator presubmit Ci-operator config changed
pull-ci-openshift-ocm-agent-operator-master-e2e-binary-build-success openshift/ocm-agent-operator presubmit Ci-operator config changed
pull-ci-openshift-ocm-agent-operator-master-images openshift/ocm-agent-operator presubmit Ci-operator config changed
pull-ci-openshift-ocm-agent-operator-master-lint openshift/ocm-agent-operator presubmit Ci-operator config changed
pull-ci-openshift-ocm-agent-operator-master-test openshift/ocm-agent-operator presubmit Ci-operator config changed
pull-ci-openshift-ocm-agent-operator-master-validate openshift/ocm-agent-operator presubmit Ci-operator config changed
pull-ci-openshift-managed-upgrade-operator-master-rosa-sts-e2e openshift/managed-upgrade-operator presubmit Presubmit changed
pull-ci-openshift-managed-upgrade-operator-master-coverage openshift/managed-upgrade-operator presubmit Ci-operator config changed
pull-ci-openshift-managed-upgrade-operator-master-e2e-binary-build-success openshift/managed-upgrade-operator presubmit Ci-operator config changed
pull-ci-openshift-managed-upgrade-operator-master-images openshift/managed-upgrade-operator presubmit Ci-operator config changed

A total of 45 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dustman9000

dustman9000 commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e pull-ci-openshift-route-monitor-operator-master-rosa-sts-e2e pull-ci-openshift-managed-upgrade-operator-master-rosa-sts-e2e

@openshift-merge-bot

openshift-merge-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dustman9000

dustman9000 commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse periodic-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e-promotion-int periodic-ci-openshift-route-monitor-operator-master-rosa-sts-e2e-promotion-stage periodic-ci-openshift-managed-upgrade-operator-master-rosa-sts-e2e-promotion-int

@openshift-merge-bot

openshift-merge-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dustman9000

dustman9000 commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

Closing: ci-operator requires releases.latest when dockerfile_literal images use FROM src. The release import can't be removed without refactoring how the e2e binary is built.

@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@dustman9000: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/managed-upgrade-operator/master/rosa-sts-e2e 69d2fc8 link unknown /pj-rehearse pull-ci-openshift-managed-upgrade-operator-master-rosa-sts-e2e
ci/rehearse/openshift/configure-alertmanager-operator/master/rosa-sts-e2e 69d2fc8 link unknown /pj-rehearse pull-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@coderabbitai coderabbitai Bot mentioned this pull request Jul 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charlesgong charlesgong Awaiting requested review from charlesgong
@clcollins clcollins Awaiting requested review from clcollins

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dustman9000