Skip to content

Switch submariner-addon to Go 1.26 images#82389

Open
skitt wants to merge 1 commit into
openshift:mainfrom
skitt:submariner-go1.26
Open

Switch submariner-addon to Go 1.26 images#82389
skitt wants to merge 1 commit into
openshift:mainfrom
skitt:submariner-go1.26

Conversation

@skitt

@skitt skitt commented Jul 24, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Updated Submariner add-on CI and release build configurations to use the Go 1.26 builder image (go1.26-linux) instead of Go 1.25 across main and supported release streams.
  • No other CI, test, promotion, or release settings were changed.

@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2026
@openshift-ci
openshift-ci Bot requested review from Jaanki and pruan-rht July 24, 2026 08:53
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3c37c891-6f12-4138-8a8f-80cbd4cd3b91

📥 Commits

Reviewing files that changed from the base of the PR and between 2710ffe and 9757d0c.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/stolostron/submariner-addon/stolostron-submariner-addon-release-2.14-postsubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (14)
  • ci-operator/config/openshift-priv/stolostron-submariner-addon/openshift-priv-stolostron-submariner-addon-main.yaml
  • ci-operator/config/openshift-priv/stolostron-submariner-addon/openshift-priv-stolostron-submariner-addon-release-2.14.yaml
  • ci-operator/config/openshift-priv/stolostron-submariner-addon/openshift-priv-stolostron-submariner-addon-release-2.15.yaml
  • ci-operator/config/openshift-priv/stolostron-submariner-addon/openshift-priv-stolostron-submariner-addon-release-2.16.yaml
  • ci-operator/config/openshift-priv/stolostron-submariner-addon/openshift-priv-stolostron-submariner-addon-release-2.17.yaml
  • ci-operator/config/openshift-priv/stolostron-submariner-addon/openshift-priv-stolostron-submariner-addon-release-5.0.yaml
  • ci-operator/config/openshift-priv/stolostron-submariner-addon/openshift-priv-stolostron-submariner-addon-release-5.1.yaml
  • ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-main.yaml
  • ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.14.yaml
  • ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.15.yaml
  • ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.16.yaml
  • ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.17.yaml
  • ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-5.0.yaml
  • ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-5.1.yaml
🚧 Files skipped from review as they are similar to previous changes (8)
  • ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.14.yaml
  • ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.16.yaml
  • ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-main.yaml
  • ci-operator/config/openshift-priv/stolostron-submariner-addon/openshift-priv-stolostron-submariner-addon-release-2.14.yaml
  • ci-operator/config/openshift-priv/stolostron-submariner-addon/openshift-priv-stolostron-submariner-addon-release-2.17.yaml
  • ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-5.1.yaml
  • ci-operator/config/openshift-priv/stolostron-submariner-addon/openshift-priv-stolostron-submariner-addon-release-2.16.yaml
  • ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.15.yaml

Walkthrough

The CI configurations for the Submariner add-on update their build root builder image tag from go1.25-linux to go1.26-linux across main and release variants.

Changes

Builder image update

Layer / File(s) Summary
Update builder image references
ci-operator/config/.../stolostron-submariner-addon-*.yaml
All privileged and standard main/release configurations now reference the go1.26-linux builder image tag.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: rehearsals-ack

Suggested reviewers: jaanki, pruan-rht, afcollins

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating submariner-addon CI/release configs to use Go 1.26 images.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Diff only updates Go builder image tags in ci-operator/job YAML; no test files or Ginkgo titles (It/Describe/Context/When) were changed.
Test Structure And Quality ✅ Passed PR only updates CI YAML builder image tags; no Go/Ginkgo test files or It blocks were changed, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed PR only bumps Go builder image tags in CI/job YAML; no new Ginkgo e2e tests or MicroShift-unsupported APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only bumps Go builder image tags in CI YAML; no new Ginkgo/e2e tests were added, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI config and a job image tag changed; no manifests, controllers, affinity, selectors, or topology-aware scheduling logic were introduced.
Ote Binary Stdout Contract ✅ Passed PR only updates CI YAML image tags from go1.25-linux to go1.26-linux; no Go binaries, suite setup, or stdout-writing code changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR only bumps Go builder image tags in CI/job YAML; no Ginkgo e2e tests, IPv4 literals, or external connectivity code were added.
No-Weak-Crypto ✅ Passed Only CI YAMLs changed to Go 1.26 builder tags; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto code found.
Container-Privileges ✅ Passed The PR only bumps ci-operator builder tags to go1.26; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings appear in the touched YAMLs.
No-Sensitive-Data-In-Logs ✅ Passed Only Go builder image tags changed in CI YAMLs; no logging code or sensitive-data-bearing strings were added or modified.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@skitt

skitt commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse max

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@skitt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@skitt
skitt force-pushed the submariner-go1.26 branch from 1ce2286 to 2710ffe Compare July 24, 2026 10:33
@skitt

skitt commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse max

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@skitt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@skitt
skitt force-pushed the submariner-go1.26 branch from 2710ffe to 9757d0c Compare July 24, 2026 11:28
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@skitt: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-submariner-addon-release-2.15-build stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.15-images stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.15-integration stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.15-unit stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.15-verify stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.17-build stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.17-images stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.17-integration stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.17-unit stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.17-verify stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-5.0-build stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-5.0-images stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-5.0-integration stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-5.0-unit stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-5.0-verify stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.16-build stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.16-images stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.16-integration stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.16-unit stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.16-verify stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-5.1-build stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-5.1-images stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-5.1-integration stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-5.1-unit stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-5.1-verify stolostron/submariner-addon presubmit Ci-operator config changed

A total of 36 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@skitt

skitt commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse max

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@skitt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@skitt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/stolostron/submariner-addon/release-2.13/build 1ce2286 link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.13-build
ci/rehearse/stolostron/submariner-addon/release-2.12/verify 2710ffe link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.12-verify
ci/rehearse/stolostron/submariner-addon/release-2.12/build 2710ffe link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.12-build
ci/rehearse/stolostron/submariner-addon/release-2.12/unit 2710ffe link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.12-unit
ci/rehearse/stolostron/submariner-addon/release-2.11/integration 1ce2286 link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.11-integration
ci/rehearse/stolostron/submariner-addon/release-2.13/unit 1ce2286 link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.13-unit
ci/rehearse/stolostron/submariner-addon/release-2.13/images 1ce2286 link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.13-images
ci/rehearse/stolostron/submariner-addon/release-2.11/build 1ce2286 link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.11-build
ci/rehearse/stolostron/submariner-addon/release-2.13/verify 1ce2286 link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.13-verify
ci/rehearse/stolostron/submariner-addon/release-2.11/verify 1ce2286 link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.11-verify
ci/rehearse/stolostron/submariner-addon/release-2.11/unit 1ce2286 link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.11-unit
ci/rehearse/stolostron/submariner-addon/release-2.11/images 1ce2286 link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.11-images
ci/rehearse/stolostron/submariner-addon/release-2.13/integration 1ce2286 link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.13-integration
ci/rehearse/stolostron/submariner-addon/release-2.12/images 2710ffe link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.12-images
ci/rehearse/stolostron/submariner-addon/release-2.12/integration 2710ffe link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.12-integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skitt

skitt commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse ack
/cc @tpantelis @vthapar

@openshift-ci
openshift-ci Bot requested review from tpantelis and vthapar July 24, 2026 12:52
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@skitt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant