Skip to content

fix wasb parsing blob as string instead of bytes#14983

Closed
kapopken wants to merge 16 commits into
apache:masterfrom
kapopken:feature-fix-blob-storage-return
Closed

fix wasb parsing blob as string instead of bytes#14983
kapopken wants to merge 16 commits into
apache:masterfrom
kapopken:feature-fix-blob-storage-return

Conversation

@kapopken

Copy link
Copy Markdown

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg

boring-cyborg Bot commented Mar 24, 2021

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@kapopken kapopken changed the title fixed bug wasb parsing blob as string instead of bytes fix wasb parsing blob as string instead of bytes Mar 24, 2021
@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

ryanahamilton and others added 3 commits March 24, 2021 11:58
* Adds initial router, routes, and placeholder views

* fix router tests

- fix linting with `skipLibCheck`
- fix motion warning on test with `resolutions` in `package.json`

* remove resolutions in package.json

* Upgrade to latest Chakra release

* Use username instead of id in route

* Add new UI node files to rebuild check

* Add linting dependencies

Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
- For some reason pymongo's stable inventory fetch is redirecting, I can reproduce it locally too if I try to access https://pymongo.readthedocs.io/en/stable/objects.inv from by browser.
If you import anything directly from `airflow` in cluster policy file, an import cycle will prevent the policy from getting loaded.

This PR fixes the import in the example and adds a small note warning about this.

closes: apache#14945
@kaxil

kaxil commented Mar 24, 2021

Copy link
Copy Markdown
Member

Please rebase on latest Master, failing doc build should be fixed by #14986

loustler and others added 9 commits March 24, 2021 17:07
Fix typo Allways to Always on image policy
* Adds initial router, routes, and placeholder views

* fix router tests

- fix linting with `skipLibCheck`
- fix motion warning on test with `resolutions` in `package.json`

* add login with basic auth

* add simple header/logout + readme for env

* remove unnecessary library

* add licenses

* more strict allow origin

* remove resolution

Co-authored-by: Ryan Hamilton <ryan@ryanahamilton.com>
…kapopken/airflow into feature-fix-blob-storage-return

# Conflicts:
#	airflow/providers/microsoft/azure/log/wasb_task_handler.py
#	tests/providers/microsoft/azure/log/test_wasb_task_handler.py
@kapopken kapopken requested a review from vikramkoka as a code owner March 25, 2021 08:53
@kapopken kapopken closed this Mar 25, 2021
@kapopken kapopken deleted the feature-fix-blob-storage-return branch March 25, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants