Skip to content

Fix import cycle in cluster policy examples#14973

Merged
kaxil merged 2 commits into
apache:masterfrom
dstandish:fix-import-cycle-issue
Mar 24, 2021
Merged

Fix import cycle in cluster policy examples#14973
kaxil merged 2 commits into
apache:masterfrom
dstandish:fix-import-cycle-issue

Conversation

@dstandish

Copy link
Copy Markdown
Contributor

If you import anything directly from airflow in cluster policy file, an import cycle will prevent the policy from getting loaded.

This PR fixes the import in the example and adds a small note warning about this.

closes: #14945

@github-actions

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 24, 2021
@kaxil kaxil merged commit eb91bdc into apache:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Circular import issues with airflow_local_settings.py

2 participants