Revert "Pre commit new UI (#14836)" to avoid blocking issue#14984
Merged
Conversation
This reverts commit e395fcd.
ryanahamilton
added
area:dev-tools
area:UI
ashb
approved these changes
Mar 24, 2021
ashb
left a comment
ashb
left a comment
Member
There was a problem hiding this comment.
I'll add this back in properly (and add a separate job for running React tests etc.) soon
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
Bot
added
the
full tests needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e395fcd (#14836).
There is a yarn issue intermittently occurring (seen in #14927) while executing these pre-commit hooks in the CI environment. We are pulling this out temporarily to unblock other work. Lint checks and test runs will be separated and reintroduced with the completion of #14957.
@bbovenzi and I are the only contributors for the time being, so we are and will continue running these checks locally prior to PR.