Adds initial router, routes, and placeholder views #14927
Conversation
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
f9192b9 to
804efc2
Compare
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
7a92d85 to
77180ed
Compare
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
- fix linting with `skipLibCheck` - fix motion warning on test with `resolutions` in `package.json`
21e08b6 to
83cef4f
Compare
|
lgtm |
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
When we check whether we should rebuild image, we check if the md5sum of some important files changed - which would trigger question whether to rebuild the image or not (because of changed dependencies which need to be installed). This happens for example when package.json or yarn.lock changes. Previously, all the important files had distinct names, so we stored the md5 hashes of those files with just filenames +.md5sum but they were flattened to a single directory. Unfortunately, as of apache#14927 (merged with failing build) we had two package.json and two yarn.locks and it caused overwriting of md5hash of one by the other. This triggered unnecessary rebuilding of the image in CI part which resulted in failure (because of Apache Beam dependency problem). This PR fixes it by adding parent directory to the name of the md5sum file (so we have www-package.json and ui-package.json) now. Those important files change very rarely so this incident should not happen again but we added some comments preventing it.
…4998) * Fixes problem with two different files mdsumed with the same name When we check whether we should rebuild image, we check if the md5sum of some important files changed - which would trigger question whether to rebuild the image or not (because of changed dependencies which need to be installed). This happens for example when package.json or yarn.lock changes. Previously, all the important files had distinct names, so we stored the md5 hashes of those files with just filenames +.md5sum but they were flattened to a single directory. Unfortunately, as of #14927 (merged with failing build) we had two package.json and two yarn.locks and it caused overwriting of md5hash of one by the other. This triggered unnecessary rebuilding of the image in CI part which resulted in failure (because of Apache Beam dependency problem). This PR fixes it by adding parent directory to the name of the md5sum file (so we have www-package.json and ui-package.json) now. Those important files change very rarely so this incident should not happen again but we added some comments preventing it. * Update scripts/ci/libraries/_initialization.sh Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com>
…4998) * Fixes problem with two different files mdsumed with the same name When we check whether we should rebuild image, we check if the md5sum of some important files changed - which would trigger question whether to rebuild the image or not (because of changed dependencies which need to be installed). This happens for example when package.json or yarn.lock changes. Previously, all the important files had distinct names, so we stored the md5 hashes of those files with just filenames +.md5sum but they were flattened to a single directory. Unfortunately, as of #14927 (merged with failing build) we had two package.json and two yarn.locks and it caused overwriting of md5hash of one by the other. This triggered unnecessary rebuilding of the image in CI part which resulted in failure (because of Apache Beam dependency problem). This PR fixes it by adding parent directory to the name of the md5sum file (so we have www-package.json and ui-package.json) now. Those important files change very rarely so this incident should not happen again but we added some comments preventing it. * Update scripts/ci/libraries/_initialization.sh Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com> (cherry picked from commit 775ee51)
…4998) * Fixes problem with two different files mdsumed with the same name When we check whether we should rebuild image, we check if the md5sum of some important files changed - which would trigger question whether to rebuild the image or not (because of changed dependencies which need to be installed). This happens for example when package.json or yarn.lock changes. Previously, all the important files had distinct names, so we stored the md5 hashes of those files with just filenames +.md5sum but they were flattened to a single directory. Unfortunately, as of #14927 (merged with failing build) we had two package.json and two yarn.locks and it caused overwriting of md5hash of one by the other. This triggered unnecessary rebuilding of the image in CI part which resulted in failure (because of Apache Beam dependency problem). This PR fixes it by adding parent directory to the name of the md5sum file (so we have www-package.json and ui-package.json) now. Those important files change very rarely so this incident should not happen again but we added some comments preventing it. * Update scripts/ci/libraries/_initialization.sh Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com> (cherry picked from commit 775ee51)
Replacing #14862 with this identical PR
to circumvent a NPM packaging caching issue in GitHub Actions causing static checks to fail. (checks were removed temporarily by #14984)Resolves #14802.
This adds
react-router-domwith an initial collection of Routes and corresponding placeholder view components.