Add Card Admin workspace access#92740
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3570a29fa7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a172d17cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
trjExpensify
left a comment
There was a problem hiding this comment.
Core PR for a WN project. 👍
|
🚀 Deployed to staging by https://github.com/flodnv in version: 9.4.7-0 🚀
Bundle Size Analysis (Sentry): |
Help site changes required ✅This PR adds a user-facing Card Admin workspace role and renames Admin → Workspace Admin in the member role surfaces, so the help site needs updating. The affected article is Draft PR: #93481 Changes made there:
Labels match @ShridharGoel, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Opened #93478
|
|
Deploy Blocker #93500 was identified to be related to this PR. |
|
Deploy Blocker #93501 was identified to be related to this PR. |
|
Deploy Blocker #93506 was identified to be related to this PR. |
|
Deploy Blocker #93508 was identified to be related to this PR. |
|
Deploy Blocker #93509 was identified to be related to this PR. |
|
All 3 front-end issues don't look like a DeployBlocker to me. |
Curious what @Expensify/product thinks there in terms of expected behavior. |
|
@JmillsExpensify might have a stronger opinion as this is his project, but I would think if the card admin can't invite new members to the workspace, then the select list for them is limited to returning current workspace members only. |
|
I agree. The select list for them should be limited to the current workspace members only. Or rather, we should start there for now and reassess based on customer feedback. |
|
Works for me! 👍 |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.7-4 🚀
|
| makeAdmin: () => ({ | ||
| one: 'Make admin', | ||
| other: 'Make admins', | ||
| one: 'Make workspace admin', |
There was a problem hiding this comment.
This comes from #94984. We renamed shared.workspace.people.makeAdmin from "Make admin" to "Make workspace admin", which unintentionally changed the label in the group chat participants dropdown because it reuses the same string. We should create a new translation key specifically for the group chat members case.

Explanation of Change
This adds frontend support for the Card Admin scoped workspace role.
Card Admins can access Overview, Members, Expensify Card, and Company Cards. Expensify Card and Company Cards use write-level feature checks so Card Admins can manage cards in those areas, while other workspace settings remain blocked.
This also adds Card Admin labels in member role surfaces, updates role display copy for workspace change logs, and updates imported-member role handling.
Fixed Issues
$ #90499, #90500, #90501
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-06-05.at.11.48.50.AM.mov