Company card - Name field is empty when opened as card admin

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.7-3
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #92740
Email or phone of affected tester (no customers): sdjoisdjnosjdsoidjoj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• User A has added a direct feed and assigned a card to themselves.
• User A invites User B to workspace as card admin.
• Perform steps below as card admin (User B).

1. Go to staging.new.expensify.com
2. Go to workspace settings > Company card.
3. Open User A's card.
4. Click Name.

Expected Result:

Name field will be populated with card name.

Actual Result:

Name field is empty when opened as card admin.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

To be added by Applause Leads

View all open jobs on GitHub

Bug7181267_1781533632416.1.mp4

Applause Internal Information
Exported by: Iuliia Herets
Bug ID: 7181267

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/3f3a19122740760d2d019742e06e518047eb616299feb94e52c38b1c3d280207

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #92740

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Issue Analysis

Root Cause: The Name edit page reads the card name only from the current user's per-account NVP, with no fallback. A Card Admin who is not the cardholder doesn't have that NVP entry for someone else's card, so the input is empty.

WorkspaceCompanyCardEditCardNamePage.tsx:36:

const defaultValue = customCardNames?.[cardID]; // undefined for a non-owner admin → empty input

The details page that renders the name the admin sees uses the same NVP but adds a fallback (WorkspaceCompanyCardDetailsPage.tsx:214):

title={customCardNames?.[cardID] ?? getDefaultCardName(cardholder?.displayName)}

NVP_EXPENSIFY_COMPANY_CARDS_CUSTOM_NAMES (nvp_expensify_ccCustomNames) is per-user — it only holds custom names the logged-in user set. PR #92740 gave Card Admins access to other people's cards for the first time, exposing the missing-fallback bug that was previously unreachable (only owners/full admins reached this page before).

Proposal

What is the root cause of that problem?

The edit page's input defaultValue comes from customCardNames?.[cardID], a per-user NVP (nvp_expensify_ccCustomNames) that only contains card names the logged-in user personally set. When a Card Admin opens a different user's card, that key is undefined, so the input renders empty. The card-details page that shows the name doesn't have this problem because it falls back to getDefaultCardName(cardholder?.displayName) when the NVP is missing — the edit page has no such fallback.

What changes do you think we should make in order to solve the problem?

Make the edit-page default value mirror what the details page displays, so the input is pre-populated with the same name the admin sees. In WorkspaceCompanyCardEditCardNamePage.tsx:

• Load the cardholder's personal details (PERSONAL_DETAILS_LIST indexed by the card's accountID), exactly as the details page does at WorkspaceCompanyCardDetailsPage.tsx:98.
• Change defaultValue to fall back the same way: customCardNames?.[cardID] ?? getDefaultCardName(cardholder?.displayName).

This keeps the edit field consistent with the displayed title and is the minimal change.

Investigation details & considerations

• NVP_EXPENSIFY_COMPANY_CARDS_CUSTOM_NAMES defined at src/ONYXKEYS.ts:636 as nvp_expensify_ccCustomNames, typed Record<string, string> keyed by cardID — per-user, written client-side in updateCompanyCardName (src/libs/actions/CompanyCards.ts:685-708).
• Display fallbacks: details page :214 and table row src/components/Tables/WorkspaceCompanyCardsTable/index.tsx:186 both use getDefaultCardName(...); getDefaultCardName returns "<displayName>'s card" (src/libs/CardUtils.ts:1041-1046).
• Alternative considered: also fall back to the workspace-shared card.nameValuePairs.cardTitle (the value updateCompanyCardName writes to WORKSPACE_CARDS_LIST_...). This would let an admin see/edit the real custom title an owner set, rather than the auto-generated "X's card". There appears to be a related gap where the display paths don't read nameValuePairs.cardTitle either, so a Card Admin sees the default name even when the owner set a custom one. That is a broader fix; the empty-input deploy blocker is resolved by matching the existing display fallback.
• Edge case: empty submit is already blocked by getFieldRequiredErrors validation (WorkspaceCompanyCardEditCardNamePage.tsx:52).

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/93598) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[puneetlath]

Seems minor. I'm going to demote.