Fix: show generic "Make admin" copy for group chat members#94989
Conversation
Co-authored-by: huult <huult@users.noreply.github.com>
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
|
@MelvinBot Please mark it ready and we can remove the comments within the Tests and QA Steps section since the use case is related to the offline scenario. Also, please check all the PR Author checklist items. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeScreen.Recording.2026-06-30.at.23.05.18.moviOS: HybridAppiOS: mWeb SafariScreen.Recording.2026-06-30.at.22.57.58.movMacOS: Chrome / SafariScreen.Recording.2026-06-30.at.22.36.28.mov |
|
@MelvinBot Please fix the generateTranslations error. |
Co-authored-by: huult <huult@users.noreply.github.com>
|
@MelvinBot Please revert commit 54a5f04 . |
Co-authored-by: huult <huult@users.noreply.github.com>
Co-authored-by: huult <huult@users.noreply.github.com>
…ion keys" This reverts commit 54a5f04. Co-authored-by: huult <huult@users.noreply.github.com>
|
MelvinBot has made 5 consecutive commits trying to fix CI failures. Automatic CI fix dispatches are now paused for this PR. Next steps: A human should review the recent commits and resolve the conflicting CI errors manually. |
|
My local environment can't build the native app right now, so I can't record a video at the moment. However, this bug doesn't impact cross-platform behavior. |
|
🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.26-0 🚀
|
|
🤖 I reviewed this PR against Expensify's help site files under No help site changes are required. This PR is a narrow UI copy fix: it adds a group-specific I searched
Since no article documents this button label or flow, there is nothing to keep in sync, so I did not create a docs PR. @huult, please confirm you agree that no help site changes are needed for this change. If you believe an article should document group-chat admin management, let me know and I'll draft one. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
The bulk-action dropdown shown when a group-chat admin selects members displayed "Make workspace admin" instead of the generic "Make admin".
PR #92740 renamed the shared
workspace.people.makeAdminstring from "Make admin" → "Make workspace admin" (to disambiguate it from the newly added "Make card admin"). That key is also consumed by the group-chat participants dropdown insrc/pages/DynamicReportParticipantsPage.tsx, which only ever renders for group chats (canSelectMultiplerequiresisGroupChat). As a side effect, group chats started showing the workspace-specific wording.This change:
workspace.people.makeGroupAdmin("Make admin" / "Make admins") to every locale, restoring the pre-Add Card Admin workspace access #92740 generic wording.makeGroupAdmininstead ofmakeAdmin.makeAdminuntouched, since "Make workspace admin" is still correct on the Workspace members list.Fixed Issues
$ #94984
PROPOSAL: #94984 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveScreenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari