[Due for payment 2026-07-13] [$250] Group - Make Workspace admin is shown as option when updating group member role

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.4.25-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-51931/folder/13176684/41236580/1529583162?sort=%2Bidentifier
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 11/ Chrome
App Component: Other

Action Performed:

Pre-condition: Account has a group created with at least one other member and has no workspace

Steps:

1. Sign in to staging.new.expensify.com with an account that satisfies the pre-condition above
2. Navigate to the group
3. Click on the group header > Members
4. Select one of the members (Other than the owner)
5. Click on the drop down menu (1 member selected)

Expected Result:

Options displayed should be "Remove member" and "Make admin" or "Make group admin"

Actual Result:

"Make Workspace Admin" option is displayed for a group members setting

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7195405_1782825910306.bandicam_2026-06-30_16-17-36-226.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7195405

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022071962124973563751
• Upwork Job ID: 2071962124973563751
• Last Price Increase: 2026-06-30

Issue Owner

Current Issue Owner: @mallenexpensify

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/6843715a64c16ae2ac9349ee4082ffcdda6fc94e2b489c17083c8e29757f358a

[MelvinBot]

Proposal

What is the root cause of that problem?

The bulk-action dropdown shown when an admin selects members in a group chat reuses the workspace-specific translation key. The "Make admin" option pulls workspace.people.makeAdmin, which resolves to "Make workspace admin" — text intended for the workspace members list, not a group chat.

This dropdown lives in DynamicReportParticipantsPage.tsx:284, and it is only ever rendered for group chats — selection mode is gated by canSelectMultiple = isGroupChat && isCurrentUserAdmin. So the workspace wording is shown unconditionally in the group context, which is wrong.

The single-member role selection and details pages are unaffected — they correctly use the generic common.admin / common.member strings.

Evidence

• en.ts:6405-6408 — makeAdmin: () => ({ one: 'Make workspace admin', other: 'Make workspace admins' })
• DynamicReportParticipantsPage.tsx:284 — the "make admin" bulk option uses translate('workspace.people.makeAdmin', ...)
• DynamicReportParticipantsPage.tsx:98 — canSelectMultiple (which gates this dropdown) requires isGroupChat, so this code path is group-chat-only.
• The makeAdmin key is also consumed by WorkspaceMembersPage.tsx, where "Make workspace admin" is correct — so the shared key should not be changed in place.

What changes do you think we should make in order to solve the problem?

Add a new group-specific translation key (e.g. workspace.people.makeGroupAdmin) resolving to "Make admin" / "Make admins" in en.ts and es.ts, and use it at DynamicReportParticipantsPage.tsx:284 instead of workspace.people.makeAdmin.

Do not modify the existing makeAdmin key — it is still correct for the workspace members list. The makeMember option ("Make member") on the same dropdown is already generic and needs no change.

What alternative solutions did you explore? (Optional)

Pass a context flag to makeAdmin so the same key returns group vs. workspace wording. A separate key is simpler and clearer, so it's preferred.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/94984) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[aswin-s]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On Web, when a group chat admin selects a non-owner member from Group header > Members and opens the bulk-action dropdown, the role option is labeled "Make workspace admin" even though there is no workspace involved — this is a group chat, not a policy/workspace. Expected label is "Make admin" (or "Make group admin").

What is the root cause of that problem?

src/pages/DynamicReportParticipantsPage.tsx:284 reuses the workspace-scoped translation key workspace.people.makeAdmin for the group-chat member dropdown. That key resolves at src/languages/en.ts:6405-6408 to {one: 'Make workspace admin', other: 'Make workspace admins'}. The string was authored for the workspace members page (WorkspaceMembersPage.tsx), where "workspace admin" is correct, but the same key is consumed verbatim in the group-chat participants page where the role being granted is a group admin (CONST.REPORT.ROLE.ADMIN via updateGroupChatMemberRoles), not a workspace policy admin. The displayed label therefore misrepresents the action.

What changes do you think we should make in order to solve the problem?

1. src/languages/en.ts — add a new group-scoped key (e.g. roomMembersPage.makeAdmin / makeGroupAdmin) with {one: 'Make admin', other: 'Make admins'} (and mirror in all other src/languages/*.ts files: zh-hans, pt-BR, pl, nl, ja, it, fr, es, de).
2. src/pages/DynamicReportParticipantsPage.tsx:284 — replace translate('workspace.people.makeAdmin', …) with the new group-scoped key so the group-chat dropdown reads "Make admin" instead of "Make workspace admin".
3. Optionally apply the same swap to the corresponding makeMember label at DynamicReportParticipantsPage.tsx:274 for consistency (it currently reads "Make member", which is acceptable, but a roomMembersPage-scoped key keeps the two parallel).
4. Leave WorkspaceMembersPage.tsx's usage of workspace.people.makeAdmin unchanged — the original "Make workspace admin" wording is correct there.

What alternative solutions did you explore? (Optional)

[MobileMage]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When you open a group chat's Members page, select a member (other than the owner) and open the bulk-action dropdown ("1 selected"), the menu shows a "Make Workspace Admin" option. A group chat is not a workspace/policy, so the "Workspace" wording is wrong for this context. The label should read "Make admin" (or "Make group admin").

What is the root cause of that problem?

The group Members page is rendered by DynamicReportParticipantsPage, and the bulk-action dropdown is built in bulkActionsButtonOptions. When at least one selected member has the MEMBER role, the page pushes a "make admin" option whose label is pulled from workspace.people.makeAdmin:

App/src/pages/DynamicReportParticipantsPage.tsx

Lines 281 to 290 in fb967fe

	...(isAtLeastOneMemberSelected
	? [
	{
	text: translate('workspace.people.makeAdmin', {count: selectedMembers.length}),
	value: CONST.POLICY.MEMBERS_BULK_ACTION_TYPES.MAKE_ADMIN,
	icon: icons.MakeAdmin,
	onSelected: () => changeUserRole(CONST.REPORT.ROLE.ADMIN),
	},
	]
	: []),

That key is shared with the real policy members page and is hardcoded with workspace-flavored copy:

makeAdmin: () => ({
    one: 'Make workspace admin',
    other: 'Make workspace admins',
}),

App/src/languages/en.ts

Lines 6405 to 6408 in fb967fe

	makeAdmin: () => ({
	one: 'Make workspace admin',
	other: 'Make workspace admins',
	}),

So the string is correct for WorkspaceMembersPage (which calls the same workspace.people.makeAdmin at line 513), but wrong when the same key is reused inside a group chat. Nothing else in the group flow uses the "workspace" wording: the per-member role selector (DynamicReportParticipantRoleSelectionPage) labels the admin role as plain common.admin ("Admin"), and the in-list role badge on this very page also uses common.admin. The mismatch only exists because the bulk dropdown borrows the policy translation key instead of a group-specific one.

What changes do you think we should make in order to solve the problem?

Add a new group-specific translation key and use it from the group bulk dropdown. The workspace.people namespace already pairs context-specific variants of the same action (e.g. removeWorkspaceMemberButtonTitle / removeGroupMemberButtonTitle / removeRoomMemberButtonTitle sit together at lines 6395-6397), so adding makeGroupAdmin next to makeAdmin follows the established pattern:

makeGroupAdmin: () => ({
    one: 'Make admin',
    other: 'Make admins',
}),

Then in DynamicReportParticipantsPage change the MAKE_ADMIN option's text from translate('workspace.people.makeAdmin', ...) to translate('workspace.people.makeGroupAdmin', ...) (line 284). This is the minimal correct fix: it touches only the group participants page and leaves WorkspaceMembersPage's existing workspace.people.makeAdmin call untouched, so the real workspace flow keeps its "Make workspace admin" copy. The same key would be added to the other language files. The corresponding makeMember option already reads correctly ("Make member") in both contexts, so no change is needed there.

What alternative solutions did you explore? (Optional)

Branching the existing label conditionally inside the page (e.g. ternary on isGroupChat ? translate(groupKey) : translate(adminKey)) was considered, but since this page only ever renders group chats the conditional adds no value; a dedicated group key is cleaner and self-documenting. Editing the shared workspace.people.makeAdmin string itself was rejected because it would incorrectly relabel the genuine workspace members page.

[lorretheboy]

Proposal

What is the root cause of that problem?

The group member dropdown reuses the workspace-scoped translation workspace.people.makeAdmin. That string was set to "Make workspace admin" for the Workspace Members page (where it is correct), but the group chat participants page shares the exact same key, so the group dropdown inherits the workspace wording.

The shared string is defined here:

App/src/languages/en.ts

Lines 6405 to 6408 in fb967fe

	makeAdmin: () => ({
	one: 'Make workspace admin',
	other: 'Make workspace admins',
	}),

and DynamicReportParticipantsPage (the group/report members screen) builds its "Make admin" bulk option from that same key:

App/src/pages/DynamicReportParticipantsPage.tsx

Lines 281 to 290 in fb967fe

	...(isAtLeastOneMemberSelected
	? [
	{
	text: translate('workspace.people.makeAdmin', {count: selectedMembers.length}),
	value: CONST.POLICY.MEMBERS_BULK_ACTION_TYPES.MAKE_ADMIN,
	icon: icons.MakeAdmin,
	onSelected: () => changeUserRole(CONST.REPORT.ROLE.ADMIN),
	},
	]
	: []),

So in a group with no workspace, the option reads "Make workspace admin" instead of "Make admin".

What changes do you think we should make in order to solve the problem?

Add a group-specific translation key (e.g. workspace.people.makeGroupAdmin → "Make admin" / "Make admins") in en.ts and the other languages/* files, and use it in DynamicReportParticipantsPage instead of workspace.people.makeAdmin:

In the isAtLeastOneMemberSelected branch here, swap the text to the new group key:

App/src/pages/DynamicReportParticipantsPage.tsx

Lines 281 to 290 in fb967fe

	...(isAtLeastOneMemberSelected
	? [
	{
	text: translate('workspace.people.makeAdmin', {count: selectedMembers.length}),
	value: CONST.POLICY.MEMBERS_BULK_ACTION_TYPES.MAKE_ADMIN,
	icon: icons.MakeAdmin,
	onSelected: () => changeUserRole(CONST.REPORT.ROLE.ADMIN),
	},
	]
	: []),

The Workspace Members page keeps using workspace.people.makeAdmin ("Make workspace admin"), which is correct there. makeMember already reads "Make member" and needs no change.

What alternative solutions did you explore? (Optional)

Keep one key but pass a context flag/value so the wording switches between "Make workspace admin" and "Make admin" depending on whether the screen is a group chat. Adding a dedicated key is cleaner and avoids coupling the two screens.

[KJ21-ENG]

Proposal

What is the root cause of that problem?

The group members bulk-action menu is built in DynamicReportParticipantsPage only for group chats and it updates report participant roles, but the admin action label is reused from the workspace member translations. That translation intentionally says "Make workspace admin", so a group chat role update is displayed with workspace-specific copy.

App/src/pages/DynamicReportParticipantsPage.tsx

Lines 93 to 98 in fb967fe

	const isCurrentUserAdmin = isGroupChatAdmin(report, currentUserAccountID);
	const isGroupChat = isGroupChatUtils(report);
	const isCurrentUserGroupChatAdmin = isGroupChat && isCurrentUserAdmin;
	const isFocused = useIsFocused();
	const {isOffline} = useNetwork();
	const canSelectMultiple = isGroupChat && isCurrentUserAdmin && (isSmallScreenWidth ? isMobileSelectionModeEnabled : true);

App/src/pages/DynamicReportParticipantsPage.tsx

Lines 215 to 218 in fb967fe

	const changeUserRole = (role: ValueOf<typeof CONST.REPORT.ROLE>) => {
	const accountIDsToUpdate = selectedMembers.filter((id) => report.participants?.[id].role !== role);
	updateGroupChatMemberRoles(report.reportID, accountIDsToUpdate, role);
	setSelectedMembers([]);

App/src/pages/DynamicReportParticipantsPage.tsx

Lines 264 to 287 in fb967fe

	const bulkActionsButtonOptions: Array<DropdownOption<WorkspaceMemberBulkActionType>> = [
	{
	text: translate('workspace.people.removeMembersTitle', {count: selectedMembers.length}),
	value: CONST.POLICY.MEMBERS_BULK_ACTION_TYPES.REMOVE,
	icon: icons.RemoveMembers,
	onSelected: showRemoveMembersModal,
	},
	...(isAtLeastOneAdminSelected
	? [
	{
	text: translate('workspace.people.makeMember', {count: selectedMembers.length}),
	value: CONST.POLICY.MEMBERS_BULK_ACTION_TYPES.MAKE_MEMBER,
	icon: icons.User,
	onSelected: () => changeUserRole(CONST.REPORT.ROLE.MEMBER),
	},
	]
	: []),
	...(isAtLeastOneMemberSelected
	? [
	{
	text: translate('workspace.people.makeAdmin', {count: selectedMembers.length}),
	value: CONST.POLICY.MEMBERS_BULK_ACTION_TYPES.MAKE_ADMIN,
	icon: icons.MakeAdmin,
	onSelected: () => changeUserRole(CONST.REPORT.ROLE.ADMIN),

App/src/languages/en.ts

Lines 6405 to 6408 in fb967fe

	makeAdmin: () => ({
	one: 'Make workspace admin',
	other: 'Make workspace admins',
	}),

What changes do you think we should make in order to solve the problem?

Add a group-chat-specific bulk action label, for example workspace.people.makeGroupAdmin, with singular/plural copy like "Make group admin" and "Make group admins". Then use that translation for the MAKE_ADMIN option in DynamicReportParticipantsPage instead of workspace.people.makeAdmin.

This keeps workspace member bulk actions unchanged, while the group participant menu continues to call updateGroupChatMemberRoles(..., CONST.REPORT.ROLE.ADMIN) and displays group-appropriate copy. The detail page already uses group-specific removal copy, so this follows the existing pattern of separating group participant labels from workspace labels.

App/src/pages/DynamicReportParticipantDetailsPage.tsx

Lines 104 to 115 in fb967fe

	<Button
	text={translate('workspace.people.removeGroupMemberButtonTitle')}
	onPress={() => setIsRemoveMemberConfirmModalVisible(true)}
	isDisabled={isSelectedMemberCurrentUser}
	icon={icons.RemoveMembers}
	iconStyles={StyleUtils.getTransformScaleStyle(0.8)}
	style={styles.mv5}
	/>
	<ConfirmModal
	danger
	title={translate('workspace.people.removeGroupMemberButtonTitle')}
	isVisible={isRemoveMemberConfirmModalVisible}

Test coverage:

• Add/update a component test for DynamicReportParticipantsPage that renders a group chat where the current user is admin, selects a member, opens the bulk dropdown, and verifies the admin action text is "Make group admin" instead of "Make workspace admin".
• Manually verify on web with a group that selecting a non-owner member shows "Remove member" and "Make group admin" in the selected-member dropdown.

What alternative solutions did you explore? (Optional)

Using a generic "Make admin" label would also avoid the workspace wording, but a dedicated group translation is clearer and avoids changing any existing workspace admin copy.

[abbasifaizan70]

🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @huult (External)